Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: brainiak/brainiak
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: brainiak/brainiak
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: test-cd-uv
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 5 files changed
  • 1 contributor

Commits on Jun 3, 2026

  1. Use uv in cd workflow

    @davidt0x
    davidt0x committed Jun 3, 2026
    Configuration menu
    Copy the full SHA
    d59b46b View commit details
    Browse the repository at this point in the history

  2. Fix CD package test dependencies 

    Add the MPICH library directory to the cibuildwheel Linux test environment so mpi4py can load libmpi during wheel tests.

Declare tf-keras in the conda runtime requirements because TensorFlow Probability matnormal tests import the tf_keras shim under conda.

Validation: git diff --check; uvx cibuildwheel --print-build-identifiers.
    @davidt0x
    davidt0x committed Jun 3, 2026
    Configuration menu
    Copy the full SHA
    a0c4261 View commit details
    Browse the repository at this point in the history

  3. Improve MPI timeout diagnostics 

    Replay any per-rank pytest report logs that were written before mpiexec times out, so CI exposes the underlying rank-level failure instead of only the wrapper timeout.

Also handle TimeoutExpired stdout/stderr consistently with subprocess.run(text=True), avoiding the misleading Windows decode AttributeError.

Verification: python3 -m py_compile tests/pytest_mpiexec_plugin.py; git diff --check; uvx flake8 --config tests/.flake8 tests/pytest_mpiexec_plugin.py
    @davidt0x
    davidt0x committed Jun 3, 2026
    Configuration menu
    Copy the full SHA
    6e20a5c View commit details
    Browse the repository at this point in the history

  4. Handle scalar HTFA width updates 

    NumPy 2.4 rejects assigning a length-one array into a scalar element. The HTFA width posterior update indexed Kx1 arrays and assigned the resulting shape-(1,) value into global_posterior_, which caused the cp311 cibuildwheel test to fail in test_htfa.py::test_can_run.

Convert the width prior and variance entries to scalars before computing and assigning the posterior width updates.

Verification: python3 -m py_compile src/brainiak/factoranalysis/htfa.py tests/pytest_mpiexec_plugin.py; git diff --check; uvx flake8 --config .flake8 src/brainiak/factoranalysis/htfa.py; uvx flake8 --config tests/.flake8 tests/pytest_mpiexec_plugin.py; uvx --from numpy python scalar assignment check
    @davidt0x
    davidt0x committed Jun 3, 2026
    Configuration menu
    Copy the full SHA
    0a467f4 View commit details
    Browse the repository at this point in the history

  5. Migrate CD off macos-13 runners 

    GitHub has deprecated the macos-13 runner image and the jobs are now sitting queued. Replace the Intel macOS entries in the wheel and conda CD matrices with macos-15-intel while keeping macos-14/macos-latest for Apple Silicon coverage.

Checked the rest of .github/workflows and no other macos-13 labels remain.

Verification: rg -n 'macos-13|macos-15-intel|macos-latest|macos-14' .github/workflows; git diff --check; python3 workflow scan for macos-13
    @davidt0x
    davidt0x committed Jun 3, 2026
    Configuration menu
    Copy the full SHA
    94f8f67 View commit details
    Browse the repository at this point in the history
Loading