Because the default combine_score just iterates through and applies operations, it's not smart about order of operations. This is a problem for addition and multiplication.
Consider the following scores:
The intent should be to make the score zero, because one of them is *0. But the result is actually 3, because it just applies them in order. The proper thing to do is probably to do them in order of basic operations, and then multiplicative ones. That means we have to see all of the operations first.
In general, I don't know how much sense this all makes. We might need to go back to the drawing board on this.
Because the default
combine_scorejust iterates through and applies operations, it's not smart about order of operations. This is a problem for addition and multiplication.Consider the following scores:
The intent should be to make the score zero, because one of them is
*0. But the result is actually3, because it just applies them in order. The proper thing to do is probably to do them in order of basic operations, and then multiplicative ones. That means we have to see all of the operations first.In general, I don't know how much sense this all makes. We might need to go back to the drawing board on this.