Skip to content

incorrect disparity range manipulation #188

@gfacciol

Description

@gfacciol

This line (and surrounding code) is in charge of extending the disparity range for the stereo matching:

disp_min *= (1 - np.sign(disp_min) * cfg['disp_range_extra_margin'])

But these manipulations are incorrect. If disp_min=0 to begin with, then no multiplication will ever increase the disparity range. The correct way to increase the disparity range is with:

dmin-= (dmax-dmin)* cfg['disp_range_extra_margin'])
dmax+= (dmax-dmin)* cfg['disp_range_extra_margin'])

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions