-
Notifications
You must be signed in to change notification settings - Fork 301
Description
Greetings,
I noticed what seems to be an inconsistency in the definition of station_information.json.
For the field is_virtual_station we have:
true- The station is a location without smart docking infrastructure. the station may be defined by a point (lat/lon) and/or station_area (below).
But we also have for the field station_area:
If lat/lon and station_area are both defined, the lat/lon is the significant coordinate of the station
But it is currently not possible to set lat/lon to null. This mean that even if we want to define only station_area, we are forced to define lat/lon that become the significant coordinate.
In my opinion, the solution is to be able to set lat/lon to null, because even if it possible to define a virtual station with only a single coordinate it should also be possible to defined a virtual station with only a set of coordinates.
You'll also need to make sure that either lat/lon or station_area is supplied and not null.
UPDATE: The consensus is to remove lat/lon OPTIONAL in is_virtual_station field because consumers rely on lat/lon.
Is your potential solution a breaking change?
- Yes
- No
- Unsure