Remove every bashism #282
Merged
Remove every bashism #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
c5b8ea3
to
9172083
Compare
|
https://mywiki.wooledge.org/Bashism Here is the site I used to squeeze out these bashisms. Might be helpful to Chris in future development. |
2362c89
to
a7073ca
Compare
b28d2b2
to
3a0d0ce
Compare
|
Just squeezed out the last bashisms out of dwm-titus. Ready for review / merge. |
This was referenced Sep 8, 2024
|
Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution. |
This was referenced Sep 7, 2024
|
Finished. |
5 tasks
6 tasks
|
Thanks so much looks awesome @nnyyxxxx |
ChrisTitusTech
approved these changes
Sep 15, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
I replaced every bashism with posix alternatives, I removed the custom color codes that were in almost every file (utilities), I refactored a lot of stuff (utilities), and I made it rely on the common script color codes instead of the custom ones (utilities).
Testing
Tested on bash, zsh, and dash.
Rechecked every file using
checkbashismspackageImpact
Greatly impacts the changed sections.
Issue related to PR
Checklist