Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change wget to curl #299

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Change wget to curl #299

merged 1 commit into from
Sep 15, 2024

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Sep 7, 2024 •
edited
Loading

Type of Change

  • New feature
  • Bug fix
  • Refactoring

Description

Replaces wget with curl for a more flexible approach

Testing

Works.

Issue related to PR

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

@nnyyxxxx nnyyxxxx force-pushed the testing-8 branch 2 times, most recently from c6e9218 to 88b8626 Compare September 7, 2024 07:14
cartercanedy
cartercanedy suggested changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@cartercanedy cartercanedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is def a nit, but pls combine & add -sS flags (curl -L -o ... -> curl -sSLo ...). Make the output less verbose while also showing any errors

@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Sep 7, 2024

This is def a nit, but pls combine & add -sS flags (curl -L -o ... -> curl -sSLo ...). Make the output less verbose while also showing any errors

Sure.

cartercanedy
cartercanedy approved these changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@cartercanedy cartercanedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :)

@ChrisTitusTech
Copy link
Owner

Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution.

@nnyyxxxx nnyyxxxx closed this Sep 12, 2024
@nnyyxxxx nnyyxxxx reopened this Sep 12, 2024
@nnyyxxxx
Copy link
Contributor Author

Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution.

Finished.

This was referenced Sep 14, 2024
Merged
Closed
@ChrisTitusTech ChrisTitusTech merged commit 71b11f7 into ChrisTitusTech:main Sep 15, 2024
2 checks passed
@nnyyxxxx nnyyxxxx deleted the testing-8 branch September 15, 2024 23:54
@ChrisTitusTech ChrisTitusTech added the enhancement New feature or request label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartercanedy cartercanedy cartercanedy approved these changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnyyxxxx @ChrisTitusTech @cartercanedy