Skip to content

[Bug]: Rich error test failures in develop #782

@Aurashk

Description

@Aurashk

Description

I'm getting all tests of test_process_manager_rich_errors failing on the develop branch. The first error is simple and you can fix it by adding a hasattr(self, "opmon_publisher") check to the __del__ method of the process manager. But then you get this error:

_______ test_all_methods_unhandled_exception[terminate-_terminate_impl] ________
tests/process_manager/test_process_manager_rich_errors.py:150: in test_all_methods_unhandled_exception
    process_manager_rich_error_test_suite.setup_server_and_client()
tests/process_manager/test_process_manager_rich_errors.py:45: in setup_server_and_client
    self.servicer = ConcreteProcessManager(
tests/process_manager/process_manager_mock_impls.py:42: in __init__
    super().__init__(configuration, name, session, **kwargs)
../../.venv/lib/python3.12/site-packages/drunc/process_manager/process_manager.py:64: in __init__
    self.handlerconf = LogHandlerConf(init_ers=True)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
<string>:5: in __init__
    ???
../../.venv/lib/python3.12/site-packages/daqpytools/logging/handlers.py:236: in __post_init__
    self.init_ers_stream()
../../.venv/lib/python3.12/site-packages/daqpytools/logging/handlers.py:264: in init_ers_stream
    "ers_handlers":  LogHandlerConf._get_oks_conf(),
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../.venv/lib/python3.12/site-packages/daqpytools/logging/handlers.py:313: in _get_oks_conf
    return {var: LogHandlerConf._make_ers_handler_conf(var)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../.venv/lib/python3.12/site-packages/daqpytools/logging/handlers.py:301: in _make_ers_handler_conf
    raise ERSEnvError(ers_log_level)
E   daqpytools.logging.exceptions.ERSEnvError: The environment variable DUNEDAQ_ERS_ERROR is empty

which to me looks like you need to set the DUNEDAQ_ERS_ERROR env variable in order to set init_ers=True in the log handler conf.

Steps to reproduce

run pytest in develop branch

Version and environment

latest nightly, develop

Impact

Small/Isolated

Anything else?

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions