Tags: JannisBush/wpt
Tags
Highlight pseudos use the forced-color status of their originating el… …ement Per the resolution in [1], forced-color-adjust should not be one of the supported properties [2] in highlight pseudos, and the forced-color state of highlights should be taken from the originating element. This change updates the HighlightInheritance implementation to match the resolution. There are a few parts to this: - css_properties.json5 is updated so that forced-color-adjust is no longer a valid property for highlight pseudos. But, since shipping this change for ::selection may cause compatibility issues, we introduce a new valid_for_highlight_legacy parameter that maintains the old behavior and we update valid_for_highlight, which will be used only for highlights with the new inheritance model enabled, to use the new behavior. - This uncovered an older bug where DetermineValidPropertyFilter wasn't using any filter at all for ::highlight(), ::spelling-error, and ::grammar-error. This is now fixed. - StyleResolver::ApplyInheritance is updated to propagate forced-colors status from the originating element to the corresponding highlight pseudo. The new test is disabled on Mac/Linux due to some small differences in text decoration painting between those from highlight pseudos and from non-highlight rules, unrelated to the contents of this change. [1] w3c/csswg-drafts#7264 (comment) [2] https://drafts.csswg.org/css-pseudo-4/#highlight-styling Bug: 1309835, 1024156 Change-Id: I732afd24bbba2619a6718270faa0a1d2fcb98512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3665644 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Delan Azabani <dazabani@igalia.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1009639}
Convert `popup=popup` to `popup=auto` or just `popup`
Per the [1] resolution, `popup=popup` has been renamed to `popup=auto`.
Additionally, per the [2] resolution, "boolean-like" behavior is also
supported, such that `<div popup>` means the same thing as `<div popup=auto>`. This CL implements both of these changes.
Note that this CL has one case that still needs to be fixed:
<div id=foo popup=invalid>
<script>
foo.popup === null; // false, should be true
</script>
To fix the above, I need to figure out how to specify the ReflectMissing
and ReflectInvalid values so that they mean "null".
[1] openui/open-ui#491 (comment)
[2] openui/open-ui#533 (comment)
Bug: 1307772
Change-Id: I6037c5322f7408ebd2c91690f89ecbc513c66bdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3668816
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1009383}
Test all Web IDL constructors throw if called as regular functions
[WPT] BFCache: storage events Expectation: When localStorage is modified when a page is in BFCache, storage events should NOT be fired for the page even after the page becomes active. Results: Firefox/Safari: Pass. Chromium: Fail (events are fired, https://crbug.com/1328939). Bug: 1328939, 1107415, whatwg/storage#119 Change-Id: I53c92b2d5f8f4791a43c2c702a441029fdbc7101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198458 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#1009350}
[css-ruby] Added 1 intra-base test (web-platform-tests#30238) * Added 1 intra-base test * Complexified intra-base-white-space-001 test * Update css/css-ruby/intra-base-white-space-001.html Co-authored-by: fantasai <fantasai.bugs@inkedblade.net> Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
Bump taskcluster from 44.13.7 to 44.14.0 in /tools Bumps [taskcluster](https://github.com/taskcluster/taskcluster) from 44.13.7 to 44.14.0. - [Release notes](https://github.com/taskcluster/taskcluster/releases) - [Changelog](https://github.com/taskcluster/taskcluster/blob/main/CHANGELOG.md) - [Commits](taskcluster/taskcluster@v44.13.7...v44.14.0) --- updated-dependencies: - dependency-name: taskcluster dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Do not forward focus to child frame when calling window.focus() on pa… …rent frame Differential Revision: https://phabricator.services.mozilla.com/D146446 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1757531 gecko-commit: c424ce3bbdf1f959575ad753feeceb97b97dd31b gecko-reviewers: hsivonen
Bump taskcluster from 44.13.7 to 44.14.0 in /tools Bumps [taskcluster](https://github.com/taskcluster/taskcluster) from 44.13.7 to 44.14.0. - [Release notes](https://github.com/taskcluster/taskcluster/releases) - [Changelog](https://github.com/taskcluster/taskcluster/blob/main/CHANGELOG.md) - [Commits](taskcluster/taskcluster@v44.13.7...v44.14.0) --- updated-dependencies: - dependency-name: taskcluster dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Test all Web IDL constructors throw if called as regular functions
COOP WPT: Typos fix and checks. Typos in the expected opener state were completely disregarded, allowing mistakes to slip through. We now check that we get something that makes sense, catching a couple of trivial errors along the way. Bug: 1318373 Change-Id: I3d5e909fd005faaacf6182354e4d61f241d13ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3683143 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1009514}