-
Notifications
You must be signed in to change notification settings - Fork 123
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Motivation
The pylops.waveeqprocessing.Kirchhoff operator has gone through a major restyling in #431 mostly aimed at including dynamic capabilities. From the discussions in the #431 and #418 we have identified the following areas that may need further improvement. Moreover some of the new features in such PR are so far only available for the 2D implementation.
Features to be implemented
- Add 2.5D wavelet filtering in
_wavelet_reshaping. Current roadblock is represented by the unclear definition of σ_S and σ_R in equation 2.3.7 of Safron2018 (neither in the Bleistein and Gray, 2002 paper). - Devise a new definition of
aperturenot simply based on the offset/depth ratio to be used for heterogeneous velocity models. Currently we raise a warning when a user decides to activate such aperture limitation -
Finalize discussion about the role ofsnell, and if this is actually needed at all. - Finalize discussion about angle scaling and introduce
cospoweras discussed in the PR -
Implement angle scaling with normal (instead of vertical) when anglerefl is provided - Implement all features when
dynamic=Truein 3D
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed