Handle errors from Dynamic Debug Configuration providers #202622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Dynamic Configuration provider, via its method `provideDebugConfigurations`, returns `undefined` or throws an Error, the selector in the Debug Tab is left in a borked state instead of going back to the last selected item. This was initially reported in microsoft#198798, whose fix handled some cases, but not all. This commit attempts to handle all the remaining cases.
roblourens
previously approved these changes
Jul 27, 2024
|
And you'll need to reply to the CLA bot. Not sure why it didn't show up before. |
kieferrm
previously approved these changes
Jul 27, 2024
|
@microsoft-github-policy-service agree company="Modular, Inc" |
@microsoft-github-policy-service agree company="Modular, Inc" |
|
@roblourens , thank you!! |
|
Thank you guys for the review!!! Happy to contribute with more debugging stuff. |
|
@roblourens , do you need to me to the rebase or will you manage that on your own? |
|
I'll take it from here, thanks |
rzhao271
approved these changes
Jul 29, 2024
lramos15
approved these changes
Jul 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Dynamic Configuration provider, via its method
provideDebugConfigurations, returnsundefinedor throws an Error, the selector in the Debug Tab is left in a borked state instead of going back to the last selected item. This was initially reported in #198798, whose fix handled some cases, but not all. This commit attempts to handle all the remaining cases.The easiest way to test this, is to use a provider and return an Error from
provideDebugConfigurationsor returnundefinedand make sure that the Debug Tab selector is left unchanged.Related issue: #202623