Skip to content

Handle notebook cell status bar commands with command property #282360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Copilot wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Handle notebook cell status bar commands with command property #282360

Copilot wants to merge 10 commits into from
+20 −1

Conversation

Copy link
Contributor

Copilot AI commented Dec 10, 2025 •
edited
Loading

Notebook cell status bar items failed when extensions supplied command objects with the identifier on command instead of id, causing clicks to noop.

  • Command resolution: Added a resolver that prefers id but falls back to command, supporting both workbench and extension command shapes.
  • Type clarity: Introduced a typed alias to capture both command forms for notebook status bar items.

Example:

new NotebookCellStatusBarItem(
	'Save',
	NotebookCellStatusBarAlignment.Left,
	{ command: 'httpyac.save', arguments: [cell.document, 0], title: 'save' }
);
Original prompt

This section details on the original issue you should resolve

<issue_title>command not working in NotebookCellStatusBarItemProvider</issue_title>
<issue_description>

  • VS Code Version: Insider
  • OS Version: Win10

Steps to Reproduce:

  1. create an implentation of vscode.NotebookCellStatusBarItemProvider
  2. use a command object instead of command string

working:

new vscode.NotebookCellStatusBarItem(
  '$(save)',
  vscode.NotebookCellStatusBarAlignment.Left,
  'httpyac.save',
  'save'
);

not working

new vscode.NotebookCellStatusBarItem(
   'save not working',
  vscode.NotebookCellStatusBarAlignment.Left,
  {
    command: 'httpyac.save',
    arguments: [cell.document, 0],
    title: 'save'
  },
)

save

Error in DevTools is

notificationsAlerts.ts:40 Running the contributed command: '_vscode_delegate_cmd_kp318eyt' failed.
onDidChangeNotification @ notificationsAlerts.ts:40

</issue_description>

<agent_instructions>Use the contents in the issue to perform a root cause analysis before attempting to fix the issue.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@rebornix Starting from @tanhakabir , not sure if it's extension issue or status bar context issue.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 9 commits December 10, 2025 02:07
@DonJayamanne
Support command.command for notebook cell status bar items
4aa3485 
Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
@DonJayamanne
Handle notebook status bar commands without id
553c80f 
Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
@DonJayamanne
Clarify notebook status bar command id resolution
a596f67 
Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
@DonJayamanne
Guard command.command fallback for notebook status bar
8dc2140 
Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
@DonJayamanne
Add helper to resolve notebook status bar command ids
f04a3b3 
Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
@DonJayamanne
Document notebook status bar command id resolution
a7f2723 
Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
@DonJayamanne
Simplify notebook status bar command id resolution
c100561 
Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
@DonJayamanne
Clarify notebook status bar command comment
f3edbd4 
Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
@DonJayamanne
Remove redundant comment in command resolver
0cf08b1 
Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix command not working in NotebookCellStatusBarItemProvider Handle notebook cell status bar commands with command property Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@DonJayamanne DonJayamanne

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

command not working in NotebookCellStatusBarItemProvider

2 participants

@DonJayamanne