Skip to content

Tags: morcos/bitcoin

Tags

feelogic.ver2

Toggle feelogic.ver2's commit message
Properly bound check conf_target in wallet RPC calls

feelogic.ver2.squash

Toggle feelogic.ver2.squash's commit message
Properly bound check conf_target in wallet RPC calls

rawapi.ver4.squash

Toggle rawapi.ver4.squash's commit message
Improve error reporting for estimaterawfee

rawapi.ver4.rebase

Toggle rawapi.ver4.rebase's commit message
Improve error reporting for estimaterawfee

addchange.ver3

Toggle addchange.ver3's commit message
Fix rare edge case of paying too many fees when transaction has no ch…

…ange.

Due to the iterative process of selecting new coins in each loop a new fee is
calculated that needs to be met each time.  In the typical case if the most
recent iteration of the loop produced a much smaller transaction and we have now
gathered inputs with too many fees, we can just reduce the change.  However in
the case where there is no change output, it is possible to end up with a
transaction which drastically overpays fees.  This commit addresses that case,
by creating a change output if the overpayment is large enough to support it,
this is accomplished by rerunning the transaction creation loop without
selecting new coins.

Thanks to instagibbs for working on this as well

rpcestimatechoice.ver3

Toggle rpcestimatechoice.ver3's commit message
fixup! fixup! Add RPC options for RBF, confirmation target, and conse…

…rvative fee estimation.

rpcestimatechoice.ver3.squash

Toggle rpcestimatechoice.ver3.squash's commit message
Add RPC options for RBF, confirmation target, and conservative fee es…

…timation.

Add support for setting each of these attributes on a per RPC call basis to sendtoaddress, sendmany, fundrawtransaction (already had RBF), and bumpfee (already had RBF and conf target).

rawapi.ver4

Toggle rawapi.ver4's commit message
fixup! Change API to estimaterawfee

rawapi.ver3

Toggle rawapi.ver3's commit message
fixup! Change API to estimaterawfee

rawapi.ver3.squash

Toggle rawapi.ver3.squash's commit message
Improve error reporting for estimaterawfee