Tags: morcos/bitcoin
Tags
Properly bound check conf_target in wallet RPC calls
Fix rare edge case of paying too many fees when transaction has no ch… …ange. Due to the iterative process of selecting new coins in each loop a new fee is calculated that needs to be met each time. In the typical case if the most recent iteration of the loop produced a much smaller transaction and we have now gathered inputs with too many fees, we can just reduce the change. However in the case where there is no change output, it is possible to end up with a transaction which drastically overpays fees. This commit addresses that case, by creating a change output if the overpayment is large enough to support it, this is accomplished by rerunning the transaction creation loop without selecting new coins. Thanks to instagibbs for working on this as well
fixup! fixup! Add RPC options for RBF, confirmation target, and conse… …rvative fee estimation.
Add RPC options for RBF, confirmation target, and conservative fee es… …timation. Add support for setting each of these attributes on a per RPC call basis to sendtoaddress, sendmany, fundrawtransaction (already had RBF), and bumpfee (already had RBF and conf target).