Skip to content

Better app config theme auto-complete #1869

@davestewart

Description

@davestewart

Description

Hello.

It seems the auto-complete for the global component ui theming is shallow.

We solved this in our own project with a that more accurately deeply-nests, whilst also allowing optional string properties (for variants and such like)

CleanShot 2024-06-13 at 11 01 50

It also navigates to the source on a Cmd+Click which is great!

I had a dig into the source and it seems it can be solved at source actually-deep DeepPartial implementation:

type UI = {
  primary?: string
  gray?: string
  colors?: string[]
  strategy?: Strategy
  [key: string]: any
} & FullyDeepPartial<typeof config> // <-- fix this one here

I'm happy to PR this fix.

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions