Fix undefined behaviour in update.py#1742
Merged
ErikDanielsson merged 3 commits intoAug 5, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1742 +/- ##
==========================================
- Coverage 68.47% 68.45% -0.03%
==========================================
Files 59 59
Lines 7141 7136 -5
==========================================
- Hits 4890 4885 -5
Misses 2251 2251
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fabianegli
reviewed
Aug 5, 2022
Contributor
|
Thank you for taking DiffEnum out, that was bugging me since I started working on tools 🙄 |
Co-authored-by: Fabian Egli <fabianegli@users.noreply.github.com>
fabianegli
reviewed
Aug 5, 2022
fabianegli
approved these changes
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some undefined behaviour in
update.pyin a recently merged pull request as @fabianegli pointed out in #1738 (comment). This fixes the issues mentioned there. I also took the opportunity to remove theDiffEnumclassupdate.pywhich is not used any more.PR checklist
CHANGELOG.mdis updateddocsis updated