FWIW this shouldn't be breaking your test suite if you don't have any tests in a package. It should only break in the case where you have Ginkgo tests but no suite file, in which case none of your tests are running anyway, which seems like a thing you'd want to know about.

Can you give an example of the problem you're encountering before we merge this? I feel like something else may be the problem here.

I've tested this matrix of possibilities:

package has go testing package test file: passes with ginkgo, passes with go test

$ ginkgo
=== RUN   TestBar
--- PASS: TestBar (0.00s)
PASS

Ginkgo ran 1 suite in 289.590825ms
Test Suite Passed

$ go test
PASS
ok      repl-1/bar      0.007s

package has ginkgo test file but no suite_test OR go testing tests: fails/exits 1 with ginkgo, passes/exits 0 with go test (with "testing: warning: no tests to run")

$ ginkgo
PASS
testing: warning: no tests to run
Found no test suites, did you forget to run "ginkgo bootstrap"?
Ginkgo ran 1 suite in 1.192450978s
Test Suite Failed

go test
testing: warning: no tests to run
PASS
ok      repl-1/bar      0.013s

package has ginkgo test file with suite file OR go testing test that calls ginkgo.RunSpecs(): both ginkgo and go test pass, exit 0

$ ginkgo
Running Suite: Bar Suite
========================
Random Seed: 1493130826
Will run 1 of 1 specs

•
Ran 1 of 1 Specs in 0.000 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped PASS

Ginkgo ran 1 suite in 1.334456566s
Test Suite Passed

$ go test
Running Suite: Bar Suite
========================
Random Seed: 1493130831
Will run 1 of 1 specs

•
Ran 1 of 1 Specs in 0.000 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped PASS
ok      repl-1/bar      0.013s

Package has no ginkgo or testing tests: both fail, ginkgo exits 1, go test exits 0

$ ginkgo
Found no test suites
For usage instructions:
        ginkgo help

$ echo $?
1

$ go test
?       repl-1/bar      [no test files]

$ echo $?
0

Uh oh!

Ginkgo should error if a package does not have a suite file #344

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions