Skip to content

phosphor-networkd persist-mac disable option missing -D #4055

@shaoi

Description

@shaoi

Unexpected behavior you saw
In the phosphor-networkd recipe, the PACKAGECONFIG[persist-mac] option is defined as:

PACKAGECONFIG[persist-mac] = "-Dpersist-mac=true, -persist-mac=false,,"

The disable argument is missing the -D prefix. As a result, Meson receives -persist-mac=false, which is an invalid argument and is ignored.

Expected behavior
The recipe should pass a valid disable flag to Meson so that removing the option actually disables it:

PACKAGECONFIG[persist-mac] = "-Dpersist-mac=true,-Dpersist-mac=false,,"

To Reproduce
Steps to reproduce the behavior:

  1. In a bbappend, add: PACKAGECONFIG:remove = "persist-mac".
  2. Build or run phosphor-networkd.
  3. Observe the meson configure command line includes -persist-mac=false (missing -D) and Meson errors with Unknown arguments, causing the task to fail.

Screenshots

Image

OpenBMC Information:
meta-phosphor/recipes-phosphor/network/phosphor-network_git.bb (line defining PACKAGECONFIG[persist-mac]).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions