feat(polyfills): ship with object.entries polyfill

zewa666 · zewa666 · commit 8ee1156d0469 · 2019-06-09T20:54:03.000+02:00
diff --git a/README.md b/README.md
@@ -17,10 +17,14 @@ You can find complete documentation on setup and usage in the official [Aurelia
 
 * [RxJS v6](https://github.com/ReactiveX/rxjs)
 * aurelia-dependency-injection
-* aurelia-framework
+* aurelia-templating
 * aurelia-logging
 * aurelia-pal
 
+## Polyfills
+
+* Object.entries ([MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries#Polyfill))
+
 ## Platform Support
 
 This library can be used in the **browser** and **node**.
diff --git a/src/aurelia-store.ts b/src/aurelia-store.ts
@@ -1,3 +1,4 @@
+import "./polyfills";
 import { Store, StoreOptions } from "./store";
 import { isStateHistory } from "./history";
 import { Container } from "aurelia-dependency-injection";
diff --git a/src/decorator.ts b/src/decorator.ts
@@ -19,10 +19,6 @@ export interface MultipleSelector<T, R = T | any> {
 const defaultSelector = <T>(store: Store<T>) => store.state;
 
 export function connectTo<T, R = any>(settings?: ((store: Store<T>) => Observable<R>) | ConnectToSettings<T, R>) {
-  if (!Object.entries) {
-    throw new Error("You need a polyfill for Object.entries for browsers like Internet Explorer. Example: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries#Polyfill")
-  }
-
   let $store: Store<T>;
 
   // const store = Container.instance.get(Store) as Store<T>;
diff --git a/src/polyfills.ts b/src/polyfills.ts
@@ -0,0 +1,14 @@
+/* istanbul ignore next */
+// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries#Polyfill
+if (!Object.entries) {
+  Object.entries = function(obj: any) {
+    var ownProps = Object.keys(obj),
+      i = ownProps.length,
+      resArray = new Array(i); // preallocate the Array
+    while (i--) {
+      resArray[i] = [ownProps[i], obj[ownProps[i]]];
+    }
+
+    return resArray;
+  }
+}
diff --git a/test/unit/decorator.spec.ts b/test/unit/decorator.spec.ts
@@ -29,18 +29,6 @@ describe("using decorators", () => {
     expect(typeof (component as any).bind).toBe("function");
   });
 
-  it("should throw an descriptive error if Object.entries is not available", () => {
-    const originalEntries = (Object as any).entries;
-
-    (Object as any).entries = undefined;
-
-    expect(() => {
-      connectTo();
-    }).toThrowError(/Object.entries/);
-
-    (Object as any).entries = originalEntries;
-  });
-
   it("should be possible to decorate a class and assign the subscribed result to the state property", () => {
     const { initialState } = arrange();
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+import "./polyfills";`
`1`	`2`	`import { Store, StoreOptions } from "./store";`
`2`	`3`	`import { isStateHistory } from "./history";`
`3`	`4`	`import { Container } from "aurelia-dependency-injection";`