Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need to manually compile JS binary for hashFiles utility #2770

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

vanZeben
Copy link
Contributor

This PR adds in some automation so that whenever the hashFiles.ts file or any json file within the src/Misc/expressionFunc/hashFiles/ folder is changed (meaning node dependencies), the host computer will interrupt and automatically run an npm run all to format, lint and package up the new javascript binary. It also will add that new binary to the latest commit for you so that no action is needed further.

This changes the workflow from

Make your changes -> `$ npm run all` -> `$ git commit {...}` -> `$ git push {...}`

to

Make your changes ->  `$ git commit {...}` -> `$ git push {...}`

@vanZeben vanZeben self-assigned this Aug 15, 2023
@vanZeben vanZeben requested a review from a team as a code owner August 15, 2023 21:46
@vanZeben vanZeben force-pushed the feature/vanzeben/automate-js-build branch from e96e235 to a29963b Compare August 15, 2023 21:50
@vanZeben vanZeben force-pushed the feature/vanzeben/automate-js-build branch from a29963b to b134170 Compare August 24, 2023 12:50
@vanZeben vanZeben merged commit 8dd2cec into main Aug 24, 2023
10 checks passed
@vanZeben vanZeben deleted the feature/vanzeben/automate-js-build branch August 24, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants