Re-use best sample when encoding images #100
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves re-encoding the same image when an acceptable CRF has been found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62
This PR saves users from wasting time re-encoding the same image when an image with the best CRF has already been encoded.
I'm not entirely sure how the sample encode cache works, but I assume it doesn't store the samples themselves, so if the best CRF is read from the cache instead of being searched for then we still have to encode it again.
I'm leaving this as a draft for now because I'm not confident that
output_path_with_best_crf(atauto_encode.rs:106) is done correctly. It works, but if the sample naming convention ever changes then this will break.