Skip to content

Registry server: remove client mutex #619

@theganyo

Description

@theganyo

The disableMutex variable is not thread-safe as it is globally referenced but not protected by a mutex.

That said, rather than fix this issue, I suggest we remove the client mutex entirely. Evidence this is safe:

  1. SQLite3 is thread-safe by default.
  2. The SQLite3 library we use ensures the DB was compiled for thread-safety.
  3. All tests pass still pass after removing the mutex.
  4. Running registry upload bulk discovery --jobs 100 is successful after removing the mutex.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions