Fix/placeholder color 5088 #27
Draft
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sst#5088 by adding a new optional \`placeholderText\` theme color that allows customizing the color of placeholder text in input fields and textareas. Changes: - Add \`placeholderText\` to ThemeColors type with fallback to \`textMuted\` - Apply \`placeholderColor\` prop to <input> components in dialog-select - Apply styled placeholder text to <textarea> components in dialog-prompt and prompt - Update JSON schemas to include \`placeholderText\` property - Maintain backward compatibility - existing themes work unchanged The new field follows ariane-emory's suggestion and provides a minimal, focused solution for theming placeholder text.
…opencode into fix/placeholder-color-5088
- Update TextareaOptions interface to include optional placeholderColor field - Add _placeholderColor private field and getter/setter methods to TextareaRenderable - Modify constructor to initialize placeholderColor with fallback to #666666 - Update applyPlaceholder method to use placeholderColor instead of hardcoded fg(#666666) - Update OpenCode components to use new placeholderColor prop instead of t/fg template functions - Remove unused t, fg imports from dialog-prompt and prompt components This enables consistent placeholder color theming across all input components using the same prop-based API pattern
- Remove t, fg imports from DialogPrompt and Prompt components - Change textarea components to use placeholderColor prop instead of t/fg template functions - This leverages the new placeholderColor prop added to opentui Textarea component - Provides consistent API pattern matching Input component's placeholderColor usage
…opencode into fix/placeholder-color-5088
4739143 to
d74137b
Compare
a88b2f0 to
d74137b
Compare
37df00d to
56452d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DUMMY PR, IGNORE