Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: basecamp/trix
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.1.6
Choose a base ref
...
head repository: basecamp/trix
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.1.7
Choose a head ref
  • 10 commits
  • 11 files changed
  • 4 contributors

Commits on May 8, 2024

  1. Configuration menu
    Copy the full SHA
    b0b935d View commit details
    Browse the repository at this point in the history
  2. Update custom_elements.js

    Fix whitespace
    tvongaza authored May 8, 2024
    Configuration menu
    Copy the full SHA
    eb1539c View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Support for ElementInternals and Constraint Validations

    Integrate with `<form>` elements directly through built-in support for
    [ElementInternals][].
    
    This is achieved with graceful degradation in two ways:
    
    * automatically check for browser support
    * support globally disabling through `Trix.config.editor.formAssociated = false`
    
    According to the [Form-associated custom elements][] section of [More
    capable form controls][], various behaviors that the `<trix-editor>`
    element was recreating are provided out of the box.
    
    For example, the `<label>` element support can be achieved through
    [ElementInternals.labels][]. Similarly, a `formResetCallback()` will
    fire whenever the associated `<form>` element resets.
    
    Add support for integrating with [Constraint validation][] through the
    support for the `[required]` attribute and the
    `setCustomValidity(message)` method.
    
    [Constraint validation]: https://developer.mozilla.org/en-US/docs/Web/HTML/Constraint_validation
    [#1023]: #1023
    [ElementInternals]: https://developer.mozilla.org/en-US/docs/Web/API/ElementInternals
    [Form-associated custom elements]: https://web.dev/articles/more-capable-form-controls#form-associated_custom_elements
    [More capable form controls]: https://web.dev/articles/more-capable-form-controls
    [ElementInternals.setFormValue]: https://developer.mozilla.org/en-US/docs/Web/API/ElementInternals/setFormValue
    [ElementInternals.labels]: https://developer.mozilla.org/en-US/docs/Web/API/ElementInternals/labels
    seanpdoyle committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    5806006 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Configuration menu
    Copy the full SHA
    7d3cf36 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Merge pull request #1151 from tvongaza/use-nonce-and-content-attribut…

    …e-for-csp
    
    Read the csp meta tag nonce attribute and fall back to content
    jorgemanrubia authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b2cefb4 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Extract LegacyDelegate and ElementInternalsDelegate

    Delegate implementation-specific methods and properties to the
    appropriate delegate. Set the delegate based on the
    `TrixEditorElement.formAssociated` property.
    seanpdoyle committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1cfa094 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Merge pull request #1190 from seanpdoyle/validate-required

    Support for `ElementInternals` and Constraint Validations
    jorgemanrubia authored Oct 13, 2024
    Configuration menu
    Copy the full SHA
    5c05d83 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Fix CI: .validationMessage assertion

    Resolve a [CI failure][] related to a hard-coded English validation
    message expectation failing due to an internationalized actual
    validation message value.
    
    [CI failure]: https://github.com/basecamp/trix/actions/runs/11317691021/job/31471435810#step:5:75
    seanpdoyle committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    832fc6e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1194 from seanpdoyle/fix-ci-validationMessage

    Fix CI: `.validationMessage` assertion
    jorgemanrubia authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d3cb49c View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. v2.1.7

    jorgemanrubia committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e597bc4 View commit details
    Browse the repository at this point in the history
Loading