-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Comparing changes
Open a pull request
base repository: basecamp/trix
base: v2.1.6
head repository: basecamp/trix
compare: v2.1.7
- 10 commits
- 11 files changed
- 4 contributors
Commits on May 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b0b935d - Browse repository at this point
Copy the full SHA b0b935dView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb1539c - Browse repository at this point
Copy the full SHA eb1539cView commit details
Commits on Oct 4, 2024
-
Support for
ElementInternalsand Constraint ValidationsIntegrate with `<form>` elements directly through built-in support for [ElementInternals][]. This is achieved with graceful degradation in two ways: * automatically check for browser support * support globally disabling through `Trix.config.editor.formAssociated = false` According to the [Form-associated custom elements][] section of [More capable form controls][], various behaviors that the `<trix-editor>` element was recreating are provided out of the box. For example, the `<label>` element support can be achieved through [ElementInternals.labels][]. Similarly, a `formResetCallback()` will fire whenever the associated `<form>` element resets. Add support for integrating with [Constraint validation][] through the support for the `[required]` attribute and the `setCustomValidity(message)` method. [Constraint validation]: https://developer.mozilla.org/en-US/docs/Web/HTML/Constraint_validation [#1023]: #1023 [ElementInternals]: https://developer.mozilla.org/en-US/docs/Web/API/ElementInternals [Form-associated custom elements]: https://web.dev/articles/more-capable-form-controls#form-associated_custom_elements [More capable form controls]: https://web.dev/articles/more-capable-form-controls [ElementInternals.setFormValue]: https://developer.mozilla.org/en-US/docs/Web/API/ElementInternals/setFormValue [ElementInternals.labels]: https://developer.mozilla.org/en-US/docs/Web/API/ElementInternals/labels
Configuration menu - View commit details
-
Copy full SHA for 5806006 - Browse repository at this point
Copy the full SHA 5806006View commit details
Commits on Oct 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7d3cf36 - Browse repository at this point
Copy the full SHA 7d3cf36View commit details
Commits on Oct 10, 2024
-
Merge pull request #1151 from tvongaza/use-nonce-and-content-attribut…
…e-for-csp Read the csp meta tag nonce attribute and fall back to content
Configuration menu - View commit details
-
Copy full SHA for b2cefb4 - Browse repository at this point
Copy the full SHA b2cefb4View commit details
Commits on Oct 11, 2024
-
Extract
LegacyDelegateandElementInternalsDelegateDelegate implementation-specific methods and properties to the appropriate delegate. Set the delegate based on the `TrixEditorElement.formAssociated` property.
Configuration menu - View commit details
-
Copy full SHA for 1cfa094 - Browse repository at this point
Copy the full SHA 1cfa094View commit details
Commits on Oct 13, 2024
-
Merge pull request #1190 from seanpdoyle/validate-required
Support for `ElementInternals` and Constraint Validations
Configuration menu - View commit details
-
Copy full SHA for 5c05d83 - Browse repository at this point
Copy the full SHA 5c05d83View commit details
Commits on Oct 15, 2024
-
Fix CI:
.validationMessageassertionResolve a [CI failure][] related to a hard-coded English validation message expectation failing due to an internationalized actual validation message value. [CI failure]: https://github.com/basecamp/trix/actions/runs/11317691021/job/31471435810#step:5:75
Configuration menu - View commit details
-
Copy full SHA for 832fc6e - Browse repository at this point
Copy the full SHA 832fc6eView commit details -
Merge pull request #1194 from seanpdoyle/fix-ci-validationMessage
Fix CI: `.validationMessage` assertion
Configuration menu - View commit details
-
Copy full SHA for d3cb49c - Browse repository at this point
Copy the full SHA d3cb49cView commit details
Commits on Oct 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e597bc4 - Browse repository at this point
Copy the full SHA e597bc4View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.1.6...v2.1.7