-
Notifications
You must be signed in to change notification settings - Fork 35
Description
I set up several benchmarks using the JSON adapter. Initially I used a kebab-case benchmark name, which in the Bencher settings was used for both the name and the slug. I then wanted to change the benchmark name to include spaces so it would render better in graph legends.
What I had expected to happen is that Bencher would realise that the old name and slug were the same, and my benchmark uploader would treat the benchmark reports as being relative to a slug, the same way they do Measures, because the Bencher settings show name, slug, and UUID for Benchmarks.
After changing the benchmark name, I came back later to realise that my benchmark reports had started being uploaded under a brand new benchmark, with the old name and a modified slug.
Now reading the BMF documentation more closely, I see that benchmark_name is solely arbitrary characters, while Measures are specified as any combination of name, slug, or UUID. So AFAICT the slug and UUID of a benchmark are useless, and BMF only supports uploading benchmarks on exact name string matching.
It would be ideal for BMF to support specifying slugs and/or UUIDs for benchmarks. Failing that, the Bencher settings page for benchmarks should be updated with a warning that the slug and UUID of a benchmark are ignored for uploads, and a warning that changing a benchmark name in settings must also be changed in the benchmark uploader. The docs should also have similar warnings.