-
-
Notifications
You must be signed in to change notification settings - Fork 990
🐛 Markdown skipped trivia #9742
Copy link
Copy link
Closed
Labels
A-ParserArea: parserArea: parserL-MarkdownLanguage: MarkdownLanguage: MarkdownS-Bug-confirmedStatus: report has been confirmed as a valid bugStatus: report has been confirmed as a valid bug
Metadata
Metadata
Assignees
Labels
A-ParserArea: parserArea: parserL-MarkdownLanguage: MarkdownLanguage: MarkdownS-Bug-confirmedStatus: report has been confirmed as a valid bugStatus: report has been confirmed as a valid bug
Environment information
main
What happened?
We still have skipped trivia being parsed in our parser, and need to remove it.
Here are some examples:
biome/crates/biome_markdown_parser/tests/md_test_suite/ok/header.md.snap
Line 191 in 8837bf3
biome/crates/biome_markdown_parser/tests/md_test_suite/ok/atx_heading_trailing_hash.md.snap
Line 63 in 8837bf3
biome/crates/biome_markdown_parser/tests/md_test_suite/ok/setext_heading_edge_cases.md.snap
Line 167 in 8837bf3
biome/crates/biome_markdown_parser/tests/md_test_suite/error/quote_nesting_too_deep.md.snap
Line 168 in 8837bf3
Expected result
We shouldn't use skipped trivia anymore. Maybe the best approach is to search for any instances in the lexer where we attempt to use the skipped trivia parsing.
cc @jfmcdowell
Code of Conduct