Skip to content

Using "filter_kwargs" on "create_engine" never returns matches #631

@joebeeson

Description

@joebeeson

In backends.sql:resource.sql function, utils.filter_kwargs always filters all keywords when creating the engine since create_engine's signature doesn't have any keyword arguments.

odo/odo/backends/sql.py

Lines 633 to 640 in 9fce669

@resource.register(r'(.*sql.*|oracle|redshift)(\+\w+)?://.+')
def resource_sql(uri, *args, **kwargs):
engine = create_engine(
uri,
# roundtrip through a frozenset of tuples so we can cache the dict
connect_args=kwargs.pop('connect_args', {}),
**filter_kwargs(sa.create_engine, kwargs)
)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions