@Gargony As a workaround you could cache the input properties rather than caching the output settings object. If you separate concerns and think of it more like a pipeline, it isn't as painful.

IReadOnlyDictionary<string, string> buildProperties;

private IReadOnlyDictionary<string, string> GetBuildProperties()
{
    return buildProperties ?? (buildProperties = new Dictionary<string, string>
    {
        ["MSBuildToolVersion"] = GetProperty("MSBuildToolVersion", "VS2015"),
        ["MSBuildPlatform"] = GetProperty("MSBuildPlatform", "Automatic"),
        ["Configuration"] = QueryProperty("Configuration", "Release"),
        ["MSBuildVerbosity"] = GetProperty("MSBuildVerbosity", "Minimal"),
        ["MSBuildFileLogger"] = GetProperty("MSBuildFileLogger"),
        ["MSBuildLogger"] = GetProperty("MSBuildLogger")
    });
}

private MSBuildSettings GetMSBuildSettings()
{
    var properties = GetBuildProperties();

    var settings = new MSBuildSettings();

    var arg = properties["MSBuildToolVersion"];
    if (!string.IsNullOrEmpty(arg))
    {
        settings.ToolVersion = (MSBuildToolVersion)Enum.Parse(typeof(MSBuildToolVersion), arg);
    }

    arg = properties["MSBuildPlatform"];
    if (!string.IsNullOrEmpty(arg)) {
        settings.MSBuildPlatform = (MSBuildPlatform)Enum.Parse(typeof(MSBuildPlatform), arg);
    }

    arg = properties["Configuration"];
    if (!string.IsNullOrEmpty(arg))
        settings.Configuration = arg;

    arg = properties["MSBuildVerbosity"];
    if (!string.IsNullOrEmpty(arg))
        settings.Verbosity = (Verbosity)Enum.Parse(typeof(Verbosity), arg);

    arg = properties["MSBuildFileLogger"];
    if (!string.IsNullOrEmpty(arg))
    {
        settings.FileLoggers.Add(new MSBuildFileLogger
        { 
            LogFile = File(arg), 
            Verbosity = settings.Verbosity
        });
    }

    arg = properties["MSBuildLogger"];
    if (!string.IsNullOrEmpty(arg))
        settings.ArgumentCustomization = a => a.Append($"/l:{arg}");

    return settings;
}

Uh oh!

Clone method for MSBuildSettings #2103

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions