-
Notifications
You must be signed in to change notification settings - Fork 49
Closed
Labels
kind:taskCategorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.
Description
What should we do?
- In the HTTP client, we have a test that checks that '+' signs are URL encoded only when they are part of the query param. If they are part of the path, we don't expect to encode them.
- We use Google's HTTP client to take care of the encoding
- The HTTP client team at Google has recently decided they want to always encode the '+' sign no matter where in the URL - apparently due to their own API's behavior: fix: encode plus sign in url with %2B googleapis/google-http-java-client#2094
- This breaks our test.
To mitigate, we keep using Google HTTP client 1.45.2 instead of upgrading.
We should determine whether we want to stay compliant with the previous decision to encode the '+' sign only in particular cases
- If yes => We should not rely on the HTTP client from Google for URL encoding.
- If no => Update tests and remove the fixed Google client version fix
Metadata
Metadata
Assignees
Labels
kind:taskCategorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.