Skip to content

Reject overflow emulation for Heretic/Hexen and moving of PadRejectArray #635

Reject overflow emulation for Heretic/Hexen and moving of PadRejectArray

Reject overflow emulation for Heretic/Hexen and moving of PadRejectArray #635

Triggered via pull request August 12, 2025 18:53
Status Success
Total duration 1m 57s
Artifacts

cpp-linter.yml

on: pull_request
Matrix: cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

8 warnings and 2 notices
src/p_rejectpad.h:21:9 [bugprone-reserved-identifier]: src/p_rejectpad.h#L21
declaration uses identifier '__P_REJECTPAD__', which is a reserved identifier
src/p_rejectpad.c:30:34 [bugprone-easily-swappable-parameters]: src/p_rejectpad.c#L30
2 adjacent parameters of 'PadRejectArray' of convertible types are easily swapped by mistake
src/hexen/p_setup.c:108:8 [cppcoreguidelines-avoid-non-const-global-variables]: src/hexen/p_setup.c#L108
variable 'blockmaplump' provides global access to a non-const object; consider making the pointed-to data 'const'
src/hexen/p_setup.c:108:8 [cppcoreguidelines-avoid-non-const-global-variables]: src/hexen/p_setup.c#L108
variable 'blockmaplump' is non-const and globally accessible, consider making it const
src/hexen/p_setup.c:107:12 [cppcoreguidelines-avoid-non-const-global-variables]: src/hexen/p_setup.c#L107
variable 'totallines' is non-const and globally accessible, consider making it const
src/heretic/p_setup.c:56:8 [cppcoreguidelines-avoid-non-const-global-variables]: src/heretic/p_setup.c#L56
variable 'blockmaplump' provides global access to a non-const object; consider making the pointed-to data 'const'
src/heretic/p_setup.c:56:8 [cppcoreguidelines-avoid-non-const-global-variables]: src/heretic/p_setup.c#L56
variable 'blockmaplump' is non-const and globally accessible, consider making it const
src/heretic/p_setup.c:54:12 [cppcoreguidelines-avoid-non-const-global-variables]: src/heretic/p_setup.c#L54
variable 'totallines' is non-const and globally accessible, consider making it const
Run clang-format on src/p_rejectpad.h: src/p_rejectpad.h#L0
File src/p_rejectpad.h does not conform to Custom style guidelines. (lines 17)
Run clang-format on src/p_rejectpad.c: src/p_rejectpad.c#L0
File src/p_rejectpad.c does not conform to Custom style guidelines. (lines 39, 41, 42, 43, 44, 53, 65)