-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for php 7.3 and php 7.4 #246
Conversation
Should we just drop support for PHP5? |
Or at least drop PHP 5.5? I would then release a new major version on the weekend |
Definitely 👍 for dropping 5 completely 👍🏻 |
Great! Maybe drop also all unsupported versions: 7.0 and 7.1? |
Yes, but let’s do it step by step I would say |
Ok, so pls suggest this steps |
Drop old PHP versions and update in
|
@kubawerlos but @OskarStark suggest something different |
We can if you like but I know there are a lot of projects outside which use not or only security fixes mode php versions. I would only drop them if it causes more work for the maintainers or if it would not be possible to go further |
So since #251 was merged, what about just adding support of PHP 7.3 and 7.4 and then we'll see if it is worth it to drop 7.0 or 7.1 |
@franmomu Sounds great |
Ok guys! Now it pass all 7.x versions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! @snapshotpl
No description provided.