Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Symfony Support #250

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Update Symfony Support #250

merged 3 commits into from
Dec 5, 2019

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Dec 2, 2019 •
edited
Loading

These are the changes:

  • Remove Silex ~1.3 as is not supported since long time ago (I've just realised that there is a Silex 2.4 which has been deprecated for a year, but this one supports symfony ^4.0 packages, so I'm not sure if it should be introduced again)
    - Use phpunit 7.5 and for that I had to use also mockery > 1.0 and there was an error with nette/util that was fixed on 2.4
  • And for Symfony I bumped to the maintained versions

Closes #234

@florianeckerstorfer
Copy link
Member

Awesome, can you fix the conflict and make the tests pass?

@franmomu franmomu force-pushed the symfony_support branch 3 times, most recently from 2b47339 to 71d878f Compare December 2, 2019 12:34
@franmomu
Copy link
Contributor Author

franmomu commented Dec 2, 2019

I bumped phpunit to 6.5 and mockery to 1.2 so the php constraint with this is ^7.0. Taking a look at #246, don’t know which versions are going to be dropped, I could make a PR just dropping 5.x or wait for that PR.

@florianeckerstorfer
Copy link
Member

@franmomu If you have the time to create a PR to drop PHP 5 support, that would be awesome.

@franmomu franmomu force-pushed the symfony_support branch 3 times, most recently from 28781d6 to 8dc3dde Compare December 2, 2019 23:48
@franmomu
Copy link
Contributor Author

franmomu commented Dec 2, 2019

I have no idea why scrutinizer fails

@florianeckerstorfer florianeckerstorfer merged commit 34924a7 into cocur:master Dec 5, 2019
@franmomu franmomu deleted the symfony_support branch December 5, 2019 08:10
@franmomu franmomu mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not Symfony 5 compatible
2 participants
@franmomu @florianeckerstorfer