Update Symfony Support - #250
Merged
Merged
Conversation
Member
|
Awesome, can you fix the conflict and make the tests pass? |
franmomu
force-pushed
the
symfony_support
branch
3 times, most recently
from
December 2, 2019 12:34
2b47339 to
71d878f
Compare
Contributor
Author
|
I bumped phpunit to 6.5 and mockery to 1.2 so the php constraint with this is |
Member
|
@franmomu If you have the time to create a PR to drop PHP 5 support, that would be awesome. |
franmomu
force-pushed
the
symfony_support
branch
3 times, most recently
from
December 2, 2019 23:48
28781d6 to
8dc3dde
Compare
Contributor
Author
|
I have no idea why scrutinizer fails |
franmomu
force-pushed
the
symfony_support
branch
from
December 4, 2019 09:41
8dc3dde to
7e84821
Compare
franmomu
force-pushed
the
symfony_support
branch
from
December 4, 2019 09:45
7e84821 to
b35b8ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the changes:
- Use phpunit 7.5 and for that I had to use also mockery > 1.0 and there was an error with nette/util that was fixed on 2.4Closes #234