Skip to content

(store/pruning): Pruner does not prune commits with vote extensions #5275

@jmalicevic

Description

@jmalicevic

Bug Report

Setup

CometBFT version

v0.38.x
v1.x
main

Have you tried the latest version:

yes

What happened?

The PruneBlocks function deletes block information by appending the prefix corresponding to a particular the of data :
"BP" - Block Parts
"C" - Commit
"BH" - BlockHash

etc.

When vote extensions were introduced, a new key type was introduced as well: "EC"

However, within PruneBlocks we are never calling delete on any key prefixed with "EC". See here for where the Commits are deleted. There is no corresponding line to this for extended commits containing vote extensions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingneeds-triageThis issue/PR has not yet been triaged by the team.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions