Skip to content

Update typos action and fix reports #9299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Update typos action and fix reports #9299

merged 1 commit into from
Jun 30, 2025

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 30, 2025 •
edited
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Fixing the typos which are also user facing.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

- Fixed typos in CLI and error messages.
- Deprecated `CONTAINER_INCLUDED_POD_METRCIS` CLI environment variable in favor of `CONTAINER_INCLUDED_POD_METRICS`.

@saschagrunert saschagrunert requested a review from mrunalp as a code owner June 30, 2025 07:55
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. labels Jun 30, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from hasan4791 and klihub June 30, 2025 07:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.93%. Comparing base (632435d) to head (33c1eba).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9299      +/-   ##
==========================================
+ Coverage   66.91%   66.93%   +0.01%     
==========================================
  Files         198      198              
  Lines       27190    27197       +7     
==========================================
+ Hits        18193    18203      +10     
- Misses       7494     7495       +1     
+ Partials     1503     1499       -4
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bitoku
bitoku reviewed Jun 30, 2025
View reviewed changes
@saschagrunert
Update typos action and fix reports
33c1eba 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@bitoku bitoku mentioned this pull request Jun 30, 2025
Closed
@saschagrunert
Copy link
Member Author

/override ci/prow/ci-e2e-evented-pleg

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 30, 2025

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-evented-pleg

In response to this:

/override ci/prow/ci-e2e-evented-pleg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bitoku
Copy link
Contributor

bitoku commented Jun 30, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2edb23f into cri-o:main Jun 30, 2025
135 of 145 checks passed
@saschagrunert saschagrunert deleted the typos branch June 30, 2025 16:08
@bitoku bitoku mentioned this pull request Sep 5, 2025
Merged
@github-actions github-actions bot mentioned this pull request Sep 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitoku bitoku bitoku left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@klihub klihub Awaiting requested review from klihub

Assignees

@bitoku bitoku

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschagrunert @bitoku