Skip to content

Path Typo in CMake Warning for Extension's vcpkg.json #18765

@beryllw

Description

@beryllw

What happens?

The CMake warning for the extension contains a typo in the file path to vcpkg.json. The current warning points to an incorrect path (missing a slash), and this needs to be corrected to reflect the valid file location.

CMake Warning at CMakeLists.txt:1360 (message):
  Extension 'xxxxxx' has a vcpkg.json, but build was not run with VCPKG.
  If build fails, check out VCPKG build instructions in
  'duckdb/extension/README.md' or try manually installing the dependencies in
  /Users/path/to/extension/xxxxxxvcpkg.json

Current Incorrect Path

/path/to/extension/xxxxxxvcpkg.json

Expected Correct Path

/path/to/extension/xxxxxx/vcpkg.json

To Reproduce

  1. Develop a new extension using vcpkg
  2. Do not set the VCPKG_TOOLCHAIN_PATH environment variable
  3. Run make to build

OS:

osx_arm64

DuckDB Version:

1.3.2

DuckDB Client:

n/a

Hardware:

No response

Full Name:

Junbo Wang

Affiliation:

n/a

What is the latest build you tested with? If possible, we recommend testing with the latest nightly build.

I have not tested with any build

Did you include all relevant data sets for reproducing the issue?

Yes

Did you include all code required to reproduce the issue?

  • Yes, I have

Did you include all relevant configuration (e.g., CPU architecture, Python version, Linux distribution) to reproduce the issue?

  • Yes, I have

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions