Add VARIANT type to C API #20210
Draft
Add VARIANT type to C API #20210
+94
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8dcac2 to
a3db550
Compare
a3db550 to
8b120f1
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds VARIANT type support to DuckDB's C API, enabling language drivers to interact with tables containing variant columns. The core changes include adding the VARIANT enum type and its conversion functions.
Key Changes
- Added
DUCKDB_TYPE_VARIANTenum value to the C API type system - Implemented type conversion functions for VARIANT in the helper module
- Added comprehensive test coverage for VARIANT type operations
- Applied code formatting changes to extension header files
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/include/duckdb/main/capi/header_generation/header_base.hpp.template | Added DUCKDB_TYPE_VARIANT enum entry with documentation |
| src/include/duckdb.h | Added DUCKDB_TYPE_VARIANT to the public API along with formatting changes |
| src/main/capi/helper-c.cpp | Implemented bidirectional conversion between LogicalTypeId::VARIANT and DUCKDB_TYPE_VARIANT |
| test/api/capi/test_capi_variant.cpp | Added comprehensive test coverage for VARIANT type including queries, prepared statements, and NULL handling |
| src/include/duckdb_extension.h | Extensive formatting changes including whitespace normalization and macro consolidation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
df64db8 to
0c9de0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the VARIANT type on the C API, allowing language drivers to add support for tables with variant columns (such as appending).
I primarily just added the enum and support on the
duckdb_get_type_idfunction, but let me know if I am missing anything to make this useful.