Skip to content

[record_use] Implementation: JSON: use snake_case for tagged unions #2887

@dcharkes

Description

@dcharkes

pkgs/record_use/doc/schema/record_use.schema.json

In this file, there is an inconsistency in the Constant definition. The type property uses a mix of PascalCase and snake_case for its enum values.

  • Call.type: snake_case ("tearoff", "with_arguments")
  • Constant.type: Mixed case.
    • PascalCase: "Instance", "Null", "String"
    • snake_case: "bool", "int", "list", "map"

pkgs/hooks/doc/schema/shared/shared_definitions.schema.json

This file is consistent. All tagged unions use snake_case.

  • Asset.type: snake_case ("hooks/metadata")
  • FailureType: snake_case ("build", "infra", "uncategorized")
  • OutputStatus: snake_case ("failure", "success")

We should clean this up.

(Split from #1093)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Todo

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions