Skip to content

Empty remediation commit - ok or bad? #207

@hexagonrecursion

Description

@hexagonrecursion
  1. If remediation commits are allowed, the app will warn:

    Please note: You should avoid adding empty commits (i.e., git commit -s --allow-empty), because these will be discarded if someone rebases the branch / repo.

  2. On the other hand here the OP suggested adding a UI button that adds empty remediation commits and no one said "empty commit = bad". To me this suggests that the recommendation above does not reflect commonly accepted wisdom.

I think the concern about rebase discarding remediation commits might be moot because remediation commits contain the commit id of the specific commit they are retroactively adding a sign-off to. If the branch is rebased, the remediation commits (even if preserved) will now contain incorrect commit id.

What am I missing?

@brianwarner @gr2m

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions