it's gotten very large, and is responsible for a few different tasks:
- building the project, dockerizing, deploying to k8s
- requires a second target to build the minio binary from
master on https://github.com/minio/minio. that target may go away when the minio server becomes stable
- building the
mc binary from master on https://github.com/minio/mc, dockerizing a second image and deploying that to k8s. The build step may go away when the mc client becomes stable
- build the mc integration tests, dockerizing a third image, and deploying that to k8s
It may make sense to split the integration tests in (3) into a separate repository. Regardless, the makefile is hard to follow.
Targets should be grouped together, and have a comment for each group, and each target should also be commented.
Also, an overview of the high level targets and workflows should be on the README.
Finally, dependencies don't make a ton of sense right now. Some ideas:
docker-push could depend on docker-build but it isn't now
- does it make sense for
docker-build to depend on build-server and build at once?
it's gotten very large, and is responsible for a few different tasks:
masteron https://github.com/minio/minio. that target may go away when the minio server becomes stablemcbinary frommasteron https://github.com/minio/mc, dockerizing a second image and deploying that to k8s. The build step may go away when themcclient becomes stableIt may make sense to split the integration tests in (3) into a separate repository. Regardless, the makefile is hard to follow.
Targets should be grouped together, and have a comment for each group, and each target should also be commented.
Also, an overview of the high level targets and workflows should be on the README.
Finally, dependencies don't make a ton of sense right now. Some ideas:
docker-pushcould depend ondocker-buildbut it isn't nowdocker-buildto depend onbuild-serverandbuildat once?