Skip to content

Default behavior of http clients changed affecting third party clients #1792

@yisraelU

Description

@yisraelU

This PR introduced a change to how a specific group of characters are encoded client side, i.e. the colon character . This change is configured via a boolean field called rawHttpLabelValues and the default value is set to false. This means a change from existing behavior.
Additionally, an accompanying server side implementation for decoding was not provided, and therefore when utilizing a Smithy4s client and server together with the default behavior will result in breakage when encountering one of those characters in the URI path

Per discussion with @kubukoz , suggested plan is.

  • mark the recent release 0.18.40 as broken in the Scala Steward repo
  • subsequent pr set default for http clients to be true , and aws clients to be false. Create release after merge to rectify release
  • another pr adding server side decoding determined by the same parameter

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions