Bincompat-friendly codegen V1, initialize trait Java codegen plugin #1737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good news, so far this DOES work |
This was referenced Jun 18, 2025
c66e403 to
3fe1aa4
Compare
3fe1aa4 to
04afeb1
Compare
0ff40e5 to
a4c6988
Compare
a4c6988 to
a1d02b4
Compare
Baccata
reviewed
Jul 4, 2025
| } | ||
| @trait(selector: "structure[trait|smithy4s.meta#bincompatFriendly] > member") | ||
| @traitValidators({ |
There was a problem hiding this comment.
I see you've evolved to a higher plane of consciousness
There was a problem hiding this comment.
Only level 5 or 6 my dude
Baccata
reviewed
Jul 4, 2025
| s"Failed to compile ${baseline._1} with Scala $scalaVersion and code:\n$scalaCode" | ||
| ) { | ||
| os.proc( | ||
| "scala-cli", |
There was a problem hiding this comment.
I wanted a programmatic api for the compiler but there's no common interface for scala 2/3 :(
In any case, we need thiss
Baccata
reviewed
Jul 4, 2025
| val visitor: Lines = lines( | ||
| block(line"trait Visitor[A]")( | ||
| block({ | ||
| // In bincompat-friendly mode, we can't allow using the raw visitor - only the Default variant is safe to use. |
|
So far I think this is a pretty damn good job ! |
|
enums now work, the tests include a workaround for VirtusLab/scala-cli#3735 |
Baccata
approved these changes
Jul 17, 2025
|
@lewisjkl , could you do a review as well when time permits ? |
lewisjkl
approved these changes
Jul 17, 2025
|
work build is happy, feel free to merge on green 👍 if you beat me to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1500
Known TODOs:
PR Checklist (not all items are relevant to all PRs)