List view

Add checks specifically for code review

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

ideaIdeas for new tools/features/frameworks/...Ideas for new tools/features/frameworks/...

new-check

startedIssues we've started working onIssues we've started working on

Status: Open.

#1102 In dominikh/go-tools;

· dominikh opened on Oct 17, 2021

staticcheck: Report incorrect equality checks of time.Time values.

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

new-check

Status: Open.

#47 In dominikh/go-tools;

· dmitshur opened on Mar 1, 2017

staticcheck: misuse of slice make() and append()

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

new-check

Status: Open.

#112 In dominikh/go-tools;

· cgilmour opened on May 31, 2017

staticcheck: detect incorrectly used pointers to loop variables

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

new-check

ptaIssues that require points-to analysisIssues that require points-to analysis

Status: Open.

#163 In dominikh/go-tools;

· ainar-g opened on Aug 24, 2017

detect incorrect use of the caret operator

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

new-check

startedIssues we've started working onIssues we've started working on

Status: Open.

#326 In dominikh/go-tools;

· kevinburke opened on Aug 30, 2018

staticcheck: flag strings.ToUpper(name[:1])+name[1:]

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

needs-decisionWe have to decide if this check is feasible and desirableWe have to decide if this check is feasible and desirable

new-check

Status: Open.

#517 In dominikh/go-tools;

· dominikh opened on Jun 14, 2019

staticcheck: detect mismatching numbers of SQL bind parameters for certain scenarios

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

new-check

Status: Open.

#532 In dominikh/go-tools;

· fortytw2 opened on Jun 30, 2019

staticcheck: check for mistakenly returning a nil error

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

new-check

Status: Open.

#640 In dominikh/go-tools;

· FiloSottile opened on Oct 29, 2019

staticcheck: log.Fatal("x:", err) -> log.Fatalln

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

needs-decisionWe have to decide if this check is feasible and desirableWe have to decide if this check is feasible and desirable

new-check

Status: Open.

#686 In dominikh/go-tools;

· dominikh opened on Feb 4, 2020

staticcheck: detect uses of fmt.Sprintf for URL-like values

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

needs-decisionWe have to decide if this check is feasible and desirableWe have to decide if this check is feasible and desirable

new-check

Status: Open.

#730 In dominikh/go-tools;

· ainar-g opened on Apr 14, 2020

Detect returning nil after err != nil check

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

new-check

Status: Open.

#863 In dominikh/go-tools;

· ilinum opened on Oct 24, 2020

staticcheck: flag strings.HasSuffix with a RequestURI

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

needs-decisionWe have to decide if this check is feasible and desirableWe have to decide if this check is feasible and desirable

new-check

Status: Open.

#877 In dominikh/go-tools;

· ainar-g opened on Nov 19, 2020

staticcheck: detect invalid server shutdown calls from handler

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

needs-decisionWe have to decide if this check is feasible and desirableWe have to decide if this check is feasible and desirable

new-check

Status: Open.

#913 In dominikh/go-tools;

· ainar-g opened on Jan 22, 2021

Detect some TOCTTOU bugs

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

needs-decisionWe have to decide if this check is feasible and desirableWe have to decide if this check is feasible and desirable

new-check

Status: Open.

#946 In dominikh/go-tools;

· ainar-g opened on Mar 15, 2021

simple: suggest replacing "t1.UnixNano() >= t2.UnixNano()" with "!t1.Before(t2)" and vice-versa

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

needs-decisionWe have to decide if this check is feasible and desirableWe have to decide if this check is feasible and desirable

new-check

Status: Open.

#995 In dominikh/go-tools;

· ainar-g opened on May 13, 2021

staticcheck or codereview: printf: warn about verbs that don’t match a type parameter’s type set

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

new-check

Status: Open.

#1104 In dominikh/go-tools;

· dominikh opened on Oct 18, 2021

simple: take assignments to blank identifiers into account

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

needs-decisionWe have to decide if this check is feasible and desirableWe have to decide if this check is feasible and desirable

new-check

Status: Open.

#1106 In dominikh/go-tools;

· ainar-g opened on Oct 27, 2021

staticcheck: flag string(T) where T is a newtype of uint8 that has a String() method

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

needs-decisionWe have to decide if this check is feasible and desirableWe have to decide if this check is feasible and desirable

new-check

Status: Open.

#1119 In dominikh/go-tools;

· ainar-g opened on Nov 9, 2021

staticcheck feature request: add check when user try to modify global variable on other package

aggressiveA set of checks that is more prone to false positives but is helpful during code reviewA set of checks that is more prone to false positives but is helpful during code review

needs-decisionWe have to decide if this check is feasible and desirableWe have to decide if this check is feasible and desirable

new-check

Status: Open.

#1152 In dominikh/go-tools;

· win-t opened on Dec 28, 2021

SA1019: support fields in generic structs

false-negative

go1.19Work to do once/in time for when Go 1.19 releasesWork to do once/in time for when Go 1.19 releases

Status: Open.

#1215 In dominikh/go-tools;

· dominikh opened on Mar 24, 2022