Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: droyo/go-xml
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: droyo/go-xml
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: issue-25
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 11 files changed
  • 1 contributor

Commits on Jan 3, 2019

  1. Fix bug when modifying the last type declaration in a schema.

    In the original code, there were two calls to
    
    	root.Children = append(root.Children, t)
    
    Because the `Children` field is a `[]xmltree.Element`, rather than an `[]*xmltree.Element`,
    if the call to `append()` causes a reallocation, of the underlying array, then the `el` pointer
    used within the same loop will no longer point to the current value, and updates to it will
    be lost, as the added test demonstrated.
    
    A better change would be to factor out the rearrangement of XMl such as
    
    	<element name="foo">
    	  <complexType name="foo">
    	    ...
    	  </complexType>
    	</element>
    
    to
    
    	<element name="foo" type="foo"/>
    	<complexType name="foo">
    	  ...
    	</complexType>
    
    in a separate pass, rather than doing it in two places (the
    `copyEltNamesToAnonymousTypes` and `nameAnonymousTypes` functions).
    droyo committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    48d1a5a View commit details
    Browse the repository at this point in the history
  2. remove unused xmlns constants

    droyo committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    76b45e2 View commit details
    Browse the repository at this point in the history
  3. Groundwork for generating tests for wsdlgen

    Updates the `testgen` tool to also generate files with `wsdlgen` if there
    is a `.wsdl` file present in `gentests`'s subdirectories. Currently
    it only generates the types & methods to use the API, no unit tests
    yet. I've added an example wsdl doc; the common "stock quote" example
    used in w3's docs and elsewhere.
    droyo committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    dec1491 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2019

  1. Configuration menu
    Copy the full SHA
    174a462 View commit details
    Browse the repository at this point in the history
Loading