Upgrade react-native 0.72.0-rc.5 #22588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fc3bbf
to
c1fe445
Compare
65c2054
to
244f7f8
Compare
This reverts commit d3956ee.
Kudo
commented
Jun 6, 2023
| @@ -61,6 +61,8 @@ Pod::Spec.new do |s| | |||
| s.dependency "expo-dev-menu" | |||
| s.dependency "ExpoModulesCore" | |||
|
|
|||
| install_modules_dependencies(s) | |||
There was a problem hiding this comment.
Suggested change
| install_modules_dependencies(s) | |
| unless defined?(install_modules_dependencies) | |
| # `install_modules_dependencies` is defined from react_native_pods.rb. | |
| # when running with `pod ipc spec`, this method is not defined and we have to require manually. | |
| require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods") | |
| end | |
| install_modules_dependencies(s) |
There was a problem hiding this comment.
Just leaving a note that this check is required for pod ipc spec command that converts the podspec into a JSON. We use it in versioning, but it runs without executing the Podfile and in that context React Native script that defines this function is not imported.
2 tasks
tsapeta
approved these changes
Jun 6, 2023
| @@ -35,7 +35,7 @@ concurrency: | |||
| jobs: | |||
| test: | |||
| runs-on: macos-12 | |||
| timeout-minutes: 120 | |||
| timeout-minutes: 150 | |||
There was a problem hiding this comment.
building hermes requires more time than usual 🤦♂️
| @@ -61,6 +61,8 @@ Pod::Spec.new do |s| | |||
| s.dependency "expo-dev-menu" | |||
| s.dependency "ExpoModulesCore" | |||
|
|
|||
| install_modules_dependencies(s) | |||
There was a problem hiding this comment.
Just leaving a note that this check is required for pod ipc spec command that converts the podspec into a JSON. We use it in versioning, but it runs without executing the Podfile and in that context React Native script that defines this function is not imported.
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@swmansion.com>
Kudo
commented
Jun 7, 2023
| @@ -490,7 +490,7 @@ describe('JS API tests', () => { | |||
| jestExpect(isEmbeddedAfterUpdate).toEqual('false'); | |||
| }); | |||
|
|
|||
| it('Receives expected events when update available on start', async () => { | |||
| xit('Receives expected events when update available on start', async () => { | |||
There was a problem hiding this comment.
@douglowder i'd disabled the failed test case here.
douglowder
approved these changes
Jun 7, 2023
Kudo
added a commit
that referenced
this pull request
Jun 12, 2023
# Why follow up #22588 which disabled the cli typecheck # How using types from metro and fix typing issues # Test Plan cli ci passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
upgrade react-native 0.72 for sdk 49
close ENG-8011
How
react-native 0.71.3 -> 0.72.0-rc.5metro-react-native-babel-preset 0.73.9 -> 0.76.5install_modules_dependenciesto support new architecture + use_frameworks!RCT_REMOTE_PROFILE=0to fix theRCT_ENABLE_INSPECTOR needs to be set to fulfill RCT_REMOTE_PROFILEbuild errorProgressViewIOS/ProgressBarAndroidsince they are deprecated/removed in 0.72Note
@types/jest. i was afraiding that will be a breaking change to the existing jest test code since it requires the explicit@jest/globalsimport. i didn't do this in this upgrade.Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).