Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eclipsesource/tabris-js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: eclipsesource/tabris-js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.6
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 57 files changed
  • 3 contributors

Commits on Sep 23, 2020

  1. [Doc] Adjust generator to better render some nested types

    Specifically, unions within maps is a common scenario (typically with
    "options" parameter objects) that often causes overly long lines
    breaking the tables in which they are placed. With this change these
    types can break unions in multiple lines even within maps.
    
    Change-Id: If511a67cc1ab23970eca85479990788416149e3f
    tbuschto committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    5d50c95 View commit details
    Browse the repository at this point in the history
  2. Remove "{children?: never}" from Picker jsxAttributes

    It is not necessary to explicitly disallow children for Picker and
    causes issue with TypeScript 3.9
    
    Change-Id: Ie085581064a488db2fd49f2f8b05452e242e57f6
    tbuschto committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    3c4a17e View commit details
    Browse the repository at this point in the history
  3. Add some more tests for using factories as selectors

    Change-Id: I6622f5adde42f0a421fa18f31be12ca3da5e64d9
    tbuschto committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    61b2806 View commit details
    Browse the repository at this point in the history
  4. Make WebSocket constructor parameter "protocol" optional

    In the type declarations and official spec this parameter is optional.
    
    Change-Id: Idaf35b6fa7859c0eb95b5dc998a2a6e7a7d4f4fe
    tbuschto committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    86ebc5e View commit details
    Browse the repository at this point in the history
  5. Do not exclude children in jsxAttributes of CollectionView

    Similarly to Picker/ItemPicker this causes issues with ListView using
    TypeScript 3.9.
    
    Change-Id: Ic542748bfbf9f6dbbc9ab5fe89a85d04a91dd8ec
    tbuschto committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    9b98a65 View commit details
    Browse the repository at this point in the history
  6. Fix VS Code test tasks errors in WSL

    VS Code can run tasks in WSL (Windows Subsystem for Linux), but the
    drive letter in the absolute path it uses to reference the currently
    open file differs in casing from the ones tsc derives from
    tsconfig.json. That caused tsc errors.
    
    Fixed by using relative paths.
    
    Change-Id: Ia8b283bb26d67e2ad62416d27ced653d3a6bb426
    tbuschto committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    7e42d3d View commit details
    Browse the repository at this point in the history
  7. Fix Composite set not accepting null parameter

    Change-Id: Ib0e2ba6402988ed5e6472a1d36c20555ee6bac05
    tbuschto committed Sep 23, 2020
    1 Configuration menu
    Copy the full SHA
    be680e0 View commit details
    Browse the repository at this point in the history
  8. Fix widget id being unchangeable

    While not recommended, the widget id should be able to be changed. And
    it definitely should not throw non-self-explanatory error messages.
    
    Change-Id: Ic2cdbde3d201e2af52616dea1be941d61452fd52
    tbuschto committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    e517bf4 View commit details
    Browse the repository at this point in the history
  9. Fix find method generic type declaration

    Unlike "children()" the "find" is not restricted to the type of the
    direct children of the composite.
    
    Change-Id: I34c5f9014150127767a69ddd71e5555fc47ec24b
    tbuschto committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    06f64a0 View commit details
    Browse the repository at this point in the history
  10. Fix "_listen" method declaration

    Declaration was missing second parameter.
    
    Change-Id: I789b2ac7627b0e9428adc53ffe622174edf5c561
    tbuschto committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    5efd66a View commit details
    Browse the repository at this point in the history
  11. Limit cached stack traces to 10

    Timer and promises are keeping the stack trace from their creation and
    append them to any new stack traces generated within their callback.
    However, if a timer or promise is called recursively this causes the
    equivalent of an asynchronous stack overflow due to the stored stack is
    growing infinitely.
    
    Change-Id: I8d3caae91cd5cfe86892a890477f8c573c7059e6
    tbuschto committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    8cf0d87 View commit details
    Browse the repository at this point in the history
  12. [DOC] Minor Fixes in .md and .json files

    Most fixes relate to tables that did not displayed correctly on the
    website, for example by being too wide.
    
    Change-Id: I86339a93931c43bc3b05250958da4a6db2901ac1
    tbuschto committed Sep 23, 2020
    4 Configuration menu
    Copy the full SHA
    9938f58 View commit details
    Browse the repository at this point in the history
  13. Fix </br> tags

    Change-Id: I278f7cb11edb9f9c07ee980e2c3a87f43c07e3eb
    tbuschto committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    ae52e65 View commit details
    Browse the repository at this point in the history
  14. Set version to 3.6.1

    tbuschto committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    38a5517 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Support TypeScript 3.9 and 4.x

    To make tabris TypeScript 4.x-compliant some changes are needed in the
    type declarations:
    
    * The "properties" parameter of "set" overrides need to assignable to
    their respective type in the super class. This is not the case if
    properties are explicitly excluded via "Omit" but included in the super
    class. Various other mechanism to exclude read-only properties either
    don't work with specific TypeScript versions or cause breaking changes.
    Therefore these overrides are removed. Regrettably this means that it is
    now possible (at compile-time) to use "set" to set read-only values,
    though they are still excluded from the constructors.
    
    * The same issue applies to jsxAttributes, but here a workaround is
    possible: Instead of omitting attribute they are joined with "never".
    This means they are still auto-suggested by the IDE, but actually using
    them causes a compile error. This workaround is possible because it is
    assumed that the JSXAttribues<T> type is (unlike Properties<T>) is never
    used outside of class declarations.
    
    * NativeObject property "_nativeType" must be declared with an explicit
    getter to able to override it with one, as is the established way to
    define it in code. To allow this the declarations generator and api json
    schema need to be extended. This includes a minor unrelated fix in
    api-schema.d.ts
    
    * d.ts files may can longer be linted by eslint. The reason for this is
    unclear.
    
    Change-Id: I58fbceab2df94f03ebe658173965d5fdc7b60751
    tbuschto committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    8045159 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Added: "timeout" parameter to "RequestInit"

    To remove TypeScript warning via concluded declaration file.
    
    Change-Id: I7be01417d69e1d5ad4bfa424bda7a47681362e97
    nea authored and tbuschto committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    a93f7ca View commit details
    Browse the repository at this point in the history
  2. [Doc] Minor fixes

    Add a space before <br/> tags in api json files. In the generated JsDoc
    the <br/> tags are completely ignored by VS code, not even adding a
    space.
    
    Fix some links to JSX.md, not renamed declarative-ui.md
    
    Various typos.
    
    Change-Id: I9dac10e2043fc29498e7b05b1a0b110f08a2308e
    tbuschto committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    fe22c64 View commit details
    Browse the repository at this point in the history
  3. Fix return value of Crypto#getRandomValues()

    It should return the same array passed to it [1].
    
    [1]: https://developer.mozilla.org/en-US/docs/Web/API/Crypto/getRandomValues#Return_value
    
    Change-Id: I4d7095d762bc50f4d5170d61aad8440634bbe91e
    cpetrov authored and tbuschto committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    699a9f6 View commit details
    Browse the repository at this point in the history
Loading