-
Notifications
You must be signed in to change notification settings - Fork 172
Comparing changes
Open a pull request
base repository: eclipsesource/tabris-js
base: master
head repository: eclipsesource/tabris-js
compare: 3.6
- 18 commits
- 57 files changed
- 3 contributors
Commits on Sep 23, 2020
-
[Doc] Adjust generator to better render some nested types
Specifically, unions within maps is a common scenario (typically with "options" parameter objects) that often causes overly long lines breaking the tables in which they are placed. With this change these types can break unions in multiple lines even within maps. Change-Id: If511a67cc1ab23970eca85479990788416149e3f
Configuration menu - View commit details
-
Copy full SHA for 5d50c95 - Browse repository at this point
Copy the full SHA 5d50c95View commit details -
Remove "{children?: never}" from Picker jsxAttributes
It is not necessary to explicitly disallow children for Picker and causes issue with TypeScript 3.9 Change-Id: Ie085581064a488db2fd49f2f8b05452e242e57f6
Configuration menu - View commit details
-
Copy full SHA for 3c4a17e - Browse repository at this point
Copy the full SHA 3c4a17eView commit details -
Add some more tests for using factories as selectors
Change-Id: I6622f5adde42f0a421fa18f31be12ca3da5e64d9
Configuration menu - View commit details
-
Copy full SHA for 61b2806 - Browse repository at this point
Copy the full SHA 61b2806View commit details -
Make WebSocket constructor parameter "protocol" optional
In the type declarations and official spec this parameter is optional. Change-Id: Idaf35b6fa7859c0eb95b5dc998a2a6e7a7d4f4fe
Configuration menu - View commit details
-
Copy full SHA for 86ebc5e - Browse repository at this point
Copy the full SHA 86ebc5eView commit details -
Do not exclude children in jsxAttributes of CollectionView
Similarly to Picker/ItemPicker this causes issues with ListView using TypeScript 3.9. Change-Id: Ic542748bfbf9f6dbbc9ab5fe89a85d04a91dd8ec
Configuration menu - View commit details
-
Copy full SHA for 9b98a65 - Browse repository at this point
Copy the full SHA 9b98a65View commit details -
Fix VS Code test tasks errors in WSL
VS Code can run tasks in WSL (Windows Subsystem for Linux), but the drive letter in the absolute path it uses to reference the currently open file differs in casing from the ones tsc derives from tsconfig.json. That caused tsc errors. Fixed by using relative paths. Change-Id: Ia8b283bb26d67e2ad62416d27ced653d3a6bb426
Configuration menu - View commit details
-
Copy full SHA for 7e42d3d - Browse repository at this point
Copy the full SHA 7e42d3dView commit details -
Fix Composite set not accepting null parameter
Change-Id: Ib0e2ba6402988ed5e6472a1d36c20555ee6bac05
1Configuration menu - View commit details
-
Copy full SHA for be680e0 - Browse repository at this point
Copy the full SHA be680e0View commit details -
Fix widget id being unchangeable
While not recommended, the widget id should be able to be changed. And it definitely should not throw non-self-explanatory error messages. Change-Id: Ic2cdbde3d201e2af52616dea1be941d61452fd52
Configuration menu - View commit details
-
Copy full SHA for e517bf4 - Browse repository at this point
Copy the full SHA e517bf4View commit details -
Fix find method generic type declaration
Unlike "children()" the "find" is not restricted to the type of the direct children of the composite. Change-Id: I34c5f9014150127767a69ddd71e5555fc47ec24b
Configuration menu - View commit details
-
Copy full SHA for 06f64a0 - Browse repository at this point
Copy the full SHA 06f64a0View commit details -
Fix "_listen" method declaration
Declaration was missing second parameter. Change-Id: I789b2ac7627b0e9428adc53ffe622174edf5c561
Configuration menu - View commit details
-
Copy full SHA for 5efd66a - Browse repository at this point
Copy the full SHA 5efd66aView commit details -
Limit cached stack traces to 10
Timer and promises are keeping the stack trace from their creation and append them to any new stack traces generated within their callback. However, if a timer or promise is called recursively this causes the equivalent of an asynchronous stack overflow due to the stored stack is growing infinitely. Change-Id: I8d3caae91cd5cfe86892a890477f8c573c7059e6
Configuration menu - View commit details
-
Copy full SHA for 8cf0d87 - Browse repository at this point
Copy the full SHA 8cf0d87View commit details -
[DOC] Minor Fixes in .md and .json files
Most fixes relate to tables that did not displayed correctly on the website, for example by being too wide. Change-Id: I86339a93931c43bc3b05250958da4a6db2901ac1
4Configuration menu - View commit details
-
Copy full SHA for 9938f58 - Browse repository at this point
Copy the full SHA 9938f58View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae52e65 - Browse repository at this point
Copy the full SHA ae52e65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38a5517 - Browse repository at this point
Copy the full SHA 38a5517View commit details
Commits on Sep 30, 2020
-
Support TypeScript 3.9 and 4.x
To make tabris TypeScript 4.x-compliant some changes are needed in the type declarations: * The "properties" parameter of "set" overrides need to assignable to their respective type in the super class. This is not the case if properties are explicitly excluded via "Omit" but included in the super class. Various other mechanism to exclude read-only properties either don't work with specific TypeScript versions or cause breaking changes. Therefore these overrides are removed. Regrettably this means that it is now possible (at compile-time) to use "set" to set read-only values, though they are still excluded from the constructors. * The same issue applies to jsxAttributes, but here a workaround is possible: Instead of omitting attribute they are joined with "never". This means they are still auto-suggested by the IDE, but actually using them causes a compile error. This workaround is possible because it is assumed that the JSXAttribues<T> type is (unlike Properties<T>) is never used outside of class declarations. * NativeObject property "_nativeType" must be declared with an explicit getter to able to override it with one, as is the established way to define it in code. To allow this the declarations generator and api json schema need to be extended. This includes a minor unrelated fix in api-schema.d.ts * d.ts files may can longer be linted by eslint. The reason for this is unclear. Change-Id: I58fbceab2df94f03ebe658173965d5fdc7b60751
Configuration menu - View commit details
-
Copy full SHA for 8045159 - Browse repository at this point
Copy the full SHA 8045159View commit details
Commits on Oct 1, 2020
-
Added: "timeout" parameter to "RequestInit"
To remove TypeScript warning via concluded declaration file. Change-Id: I7be01417d69e1d5ad4bfa424bda7a47681362e97
Configuration menu - View commit details
-
Copy full SHA for a93f7ca - Browse repository at this point
Copy the full SHA a93f7caView commit details -
Add a space before <br/> tags in api json files. In the generated JsDoc the <br/> tags are completely ignored by VS code, not even adding a space. Fix some links to JSX.md, not renamed declarative-ui.md Various typos. Change-Id: I9dac10e2043fc29498e7b05b1a0b110f08a2308e
Configuration menu - View commit details
-
Copy full SHA for fe22c64 - Browse repository at this point
Copy the full SHA fe22c64View commit details -
Fix return value of Crypto#getRandomValues()
It should return the same array passed to it [1]. [1]: https://developer.mozilla.org/en-US/docs/Web/API/Crypto/getRandomValues#Return_value Change-Id: I4d7095d762bc50f4d5170d61aad8440634bbe91e
Configuration menu - View commit details
-
Copy full SHA for 699a9f6 - Browse repository at this point
Copy the full SHA 699a9f6View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...3.6