-
Notifications
You must be signed in to change notification settings - Fork 172
Comparing changes
Open a pull request
base repository: eclipsesource/tabris-js
base: master
head repository: eclipsesource/tabris-js
compare: 3.7
- 12 commits
- 25 files changed
- 3 contributors
Commits on Dec 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0a3f5ff - Browse repository at this point
Copy the full SHA 0a3f5ffView commit details -
Don't skip native "dispose" operation for children excluded from layout
When a composite is disposed no individual "dispose" operations are sent to the native client for the children. This is because the native client is already aware of the children and can dispose them directly. However, in case "excludeFromLayout" is set to true the widget is no longer attached to it's parent on the native side. This caused a memory leak since these children effectively become orphans, marked as disposed in JavaScript but still in memory on the native side. Change-Id: Iaa2eead31251afdd0355a2007fb4b313ebcea805
Configuration menu - View commit details
-
Copy full SHA for 1ab0b14 - Browse repository at this point
Copy the full SHA 1ab0b14View commit details -
CanvasContext is wrapping a "GC" NativeObject that needs to be disposed. While the Canvas is set as the "parent" of the GC, the usual mechanism that automatically disposes children of a widget is not in effect here, so the GC needs to be disposed explicitly. Fix #2130 Change-Id: Ic71e7b99a5160d37c636cfaffc8d371691ee849f
Configuration menu - View commit details
-
Copy full SHA for 9bf0344 - Browse repository at this point
Copy the full SHA 9bf0344View commit details
Commits on Apr 16, 2021
-
Mark Tabris object properties as "const"
These properties can't be changed and have no change events. The documentation and type declarations need to reflect that. Change-Id: If561c3487a23869fcb995c72630842bb7522b022
Configuration menu - View commit details
-
Copy full SHA for 3c8ca25 - Browse repository at this point
Copy the full SHA 3c8ca25View commit details -
Fix Popups not firing "close" event when closed programmatically
The native side sends a close event if the popup is closed either by user input, or when disposed from JS, which is all that the "close" method does. However, disposed native objects can not emit events, so this is ignored and the event is missing. Refactor Popup (migrated to TypeScript) to handle close event for all subclasses and fire a close event explicitly if the close method is called (before the internal dispose call). Fix #2151 Change-Id: I403ea2c6e835560446576cd7fd5a0555640a0c8d
Configuration menu - View commit details
-
Copy full SHA for 43ff821 - Browse repository at this point
Copy the full SHA 43ff821View commit details -
Prevent widget constructors from being marked as functional components
A widget factory generated via asFactory() may be passed a "parent" factory as the second parameter to make it work as a selector. If the given function was not actually a factory but a widget constructor this would override the existing functionality of that constructor as a selector, resulting in very confusing behavior. Check that the parent factory is not a constructor for an object that can be used as a JSX Element (and therefore as a selector). Fix #2137 Change-Id: Ib0de0131436583f138adf8564914e30221771b18
Configuration menu - View commit details
-
Copy full SHA for ed9bc5e - Browse repository at this point
Copy the full SHA ed9bc5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d06002e - Browse repository at this point
Copy the full SHA d06002eView commit details
Commits on Apr 23, 2021
-
[Doc] Render snippet links to both GitHub and Playground
Also fix some MDN urls.
Configuration menu - View commit details
-
Copy full SHA for f5274ce - Browse repository at this point
Copy the full SHA f5274ceView commit details -
[Doc] Add not on translationZ support missing on iOS
Change-Id: If2a58093106f05419029f8322c23c619f4e9f1ab
Configuration menu - View commit details
-
Copy full SHA for 7ded730 - Browse repository at this point
Copy the full SHA 7ded730View commit details -
[Doc] Remove duplicate "crypto" entry from TOC
Crypto already has generated API documentation, the link to the w3c article is not necessary. Change-Id: Ic5d3d58ac906898a64cb0e087646765d0e5f13ab
Configuration menu - View commit details
-
Copy full SHA for 53309d8 - Browse repository at this point
Copy the full SHA 53309d8View commit details -
Update TextInput documentation
Since the 'TextInput#cursorColor' is now also supported on Android, the platform flag has been removed from the documentation. Change-Id: If0c7adfc89543752beb679090d436a921a9d1768
Configuration menu - View commit details
-
Copy full SHA for 8dd6cc7 - Browse repository at this point
Copy the full SHA 8dd6cc7View commit details
Commits on May 5, 2021
-
Work around an unknown ArrayBuffer bug in iOS 14.5
In one Tabris.js application we ran into a case where an empty ArrayBuffer was unexpectedly detached. That caused "Receiver is detached" type error in `slice()` method. Since we do not know for sure why and how that ArrayBuffer was happened to be detached we implement a workaround to prevent this exception. This issue was not reproducible in any lower version of iOS. Change-Id: Id4216fdde4aa000ab3a4b8d996a588c0632d5297
Configuration menu - View commit details
-
Copy full SHA for 0c1c99b - Browse repository at this point
Copy the full SHA 0c1c99bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...3.7