Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eclipsesource/tabris-js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: eclipsesource/tabris-js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.7
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 25 files changed
  • 3 contributors

Commits on Dec 16, 2020

  1. Increase version to 3.7.1

    tbuschto committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    0a3f5ff View commit details
    Browse the repository at this point in the history
  2. Don't skip native "dispose" operation for children excluded from layout

    When a composite is disposed no individual "dispose" operations are sent
    to the native client for the children. This is because the native client
    is already aware of the children and can dispose them directly.
    
    However, in case "excludeFromLayout" is set to true the widget is no
    longer attached to it's parent on the native side. This caused a
    memory leak since these children effectively become orphans, marked
    as disposed in JavaScript but still in memory on the native side.
    
    Change-Id: Iaa2eead31251afdd0355a2007fb4b313ebcea805
    tbuschto committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    1ab0b14 View commit details
    Browse the repository at this point in the history
  3. Dispose GC with Canvas

    CanvasContext is wrapping a "GC" NativeObject that needs to be
    disposed. While the Canvas is set as the "parent" of the GC, the
    usual mechanism that automatically disposes children of a widget
    is not in effect here, so the GC needs to be disposed explicitly.
    
    Fix #2130
    
    Change-Id: Ic71e7b99a5160d37c636cfaffc8d371691ee849f
    tbuschto committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    9bf0344 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Mark Tabris object properties as "const"

    These properties can't be changed and have no change events. The
    documentation and type declarations need to reflect that.
    
    Change-Id: If561c3487a23869fcb995c72630842bb7522b022
    tbuschto committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    3c8ca25 View commit details
    Browse the repository at this point in the history
  2. Fix Popups not firing "close" event when closed programmatically

    The native side sends a close event if the popup is closed either by
    user input, or when disposed from JS, which is all that the "close"
    method does. However, disposed native objects can not emit events, so
    this is ignored and the event is missing.
    
    Refactor Popup (migrated to TypeScript) to handle close event for all
    subclasses and fire a close event explicitly if the close method is
    called (before the internal dispose call).
    
    Fix #2151
    
    Change-Id: I403ea2c6e835560446576cd7fd5a0555640a0c8d
    tbuschto committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    43ff821 View commit details
    Browse the repository at this point in the history
  3. Prevent widget constructors from being marked as functional components

    A widget factory generated via asFactory() may be passed a "parent"
    factory as the second parameter to make it work as a selector. If the
    given function was not actually a factory but a widget constructor
    this would override the existing functionality of that constructor
    as a selector, resulting in very confusing behavior.
    
    Check that the parent factory is not a constructor for an object
    that can be used as a JSX Element (and therefore as a selector).
    
    Fix #2137
    
    Change-Id: Ib0de0131436583f138adf8564914e30221771b18
    tbuschto committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    ed9bc5e View commit details
    Browse the repository at this point in the history
  4. Increase version to 3.7.2

    tbuschto committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    d06002e View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. [Doc] Render snippet links to both GitHub and Playground

    Also fix some MDN urls.
    tbuschto committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    f5274ce View commit details
    Browse the repository at this point in the history
  2. [Doc] Add not on translationZ support missing on iOS

    Change-Id: If2a58093106f05419029f8322c23c619f4e9f1ab
    tbuschto committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    7ded730 View commit details
    Browse the repository at this point in the history
  3. [Doc] Remove duplicate "crypto" entry from TOC

    Crypto already has generated API documentation, the link to the w3c
    article is not necessary.
    
    Change-Id: Ic5d3d58ac906898a64cb0e087646765d0e5f13ab
    tbuschto committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    53309d8 View commit details
    Browse the repository at this point in the history
  4. Update TextInput documentation

    Since the 'TextInput#cursorColor' is now also supported on Android, the
    platform flag has been removed from the documentation.
    
    Change-Id: If0c7adfc89543752beb679090d436a921a9d1768
    elshadsm authored and tbuschto committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    8dd6cc7 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. Work around an unknown ArrayBuffer bug in iOS 14.5

    In one Tabris.js application we ran into a case where an empty
    ArrayBuffer was unexpectedly detached. That caused "Receiver is
    detached" type error in `slice()` method.
    
    Since we do not know for sure why and how that ArrayBuffer was happened
    to be detached we implement a workaround to prevent this exception.
    
    This issue was not reproducible in any lower version of iOS.
    
    Change-Id: Id4216fdde4aa000ab3a4b8d996a588c0632d5297
    karolszafranski authored and tbuschto committed May 5, 2021
    Configuration menu
    Copy the full SHA
    0c1c99b View commit details
    Browse the repository at this point in the history
Loading