Skip to content

[CRITICAL] double-multiplication of initial weight in single-pattern-source fluence output #212

@fangq

Description

@fangq

@ShijieYan helped debugging the issue reported by Haohui Zhang in this mailing list thread

https://groups.google.com/g/mcx-users/c/KEH754XnJdY

he noticed that our single-pattern simulations have been generating incorrect outputs at least since 4 years ago (v2020 and onward, may be even earlier).

in 2020, a similar bug was fixed for diffuse transmittance c04bff5, but somehow we did not apply this fix to the volumetric fluence output.

if you use photon-sharing (multiple patterns) or if you just compute diffuse transmittance, your results were not impacted by this bug.

But if you are using the fluence output from a single pattern or pattern3d source, unfortunately mcx was giving you wrong results.

This is a critical bug.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions