forked from freedomofpress/securedrop-workstation
-
Notifications
You must be signed in to change notification settings - Fork 1
Merge version 0.10.0 of freedomofpress/securedrop-workstation #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to fedora-38 as base system Fedora version
This is mostly a copy of @eaon's change in securedrop-updater[1], with one key change of normalizing the version down to a PEP 440 compatible format. Since we use setuptools's sdist to create a tarball and then expect rpmbuild to be able to find it, we need to use a common version format across both setuptools and RPM. Encoding the RC version in the `Release` field has always been wrong, since that's used for changes to packaging, not when the upstream (i.e. sdist tarball) changes. This also means we no longer need to update `Source` in the release branch to point at the tarball, since it can be inferred correctly from the existing `%{name}-%{version}.tar.gz` macros. Leave a TODO to switch to rpmdev-bumpspec which is the RPM `dch` equivalent to bump the version and insert a changelog entry. [1] freedomofpress/securedrop-updater@42a55c7 Co-authored-by: Michael Z <michael@freedom.press>
Just set `Version` in RPM spec
The RPM build container needs to be highly trustworthy, so it should only contain things from Fedora itself and any audited code. We don't audit development dependencies, so we shouldn't be installing them into the build container. We split the container used by `./scripts/container.sh` into two, a base, build container and then a container layered on top with dev dependencies. Functionally this should be a no-op since none of the dependencies are used at build time but it cuts down on the risk of malicious code injection. Fixes freedomofpress#921.
…ilds Don't install dev deps in the RPM build container
(cherry picked from commit d549929)
…0-changelog Backport SecureDrop Workstation 0.9.0 changelog
…github-actions Migrate to GitHub Actions
Enable dependabot for GitHub Actions
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…github_actions/actions/checkout-4 Bump actions/checkout from 3 to 4
We have the CURRENT_FEDORA_VERSION/TEMPLATE constants for this purpose.
…edora tests: Avoid repeating Fedora version in specific test
- Succeed if expected key is present in sd-gpg - Fail if no key is present locally or remotely
Make `gpg` tests more resilient
Specify whonix template version and use qvm.template_installed to ensure it is present. Update migration flag and vm_tests.
Support Whonix 17
…rc1-bump Update version to 0.10.0-rc1
…0.0-rc2-bump [0.10.0] Version 0.10.0 rc2 bump
- Updated sd-whonix to use the Whonix 17 gateway base template
Securedrop Workstation 0.10.0
Looks good! It seems like failed ci jobs have to do with formatting? |
Thanks @zekehuntergreen - for future reference I ran:
|
zekehuntergreen
approved these changes
Mar 12, 2024
philmcmahon
pushed a commit
that referenced
this pull request
Jul 4, 2024
Containerize build and test environment, add some developer tools (cherry picked from commit freedomofpress/securedrop-updater@9b2d169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Brings our repo up to date with https://github.com/freedomofpress/securedrop-workstation/releases/tag/0.10.0
To check that the changes being pulled in are expected, this tag comparison page is useful: freedomofpress/securedrop-workstation@0.9.0...0.10.0
To generate this PR, I ran the following git steps: