Use new build-rpm script, build on fedora container #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zekehuntergreen
approved these changes
Mar 7, 2024
3aee735 to
c7a566c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
The changes in #8 renamed the securedrop build rpm script. This PR modifies our Dockerfile and build script accordingly to work with the new script.
The main change is to use a fedora rather than Debian docker container. For some reason I was getting a load of 'dependency not found' errors when trying to build on debian. I think fedora makes a bit more sense as it's closer to the OS that dom0 on Qubes uses.