Skip to content

"--incsearch" breaks search history #507

@avih

Description

@avih

When using --incsearch, search history (accessed via UP arrow key after pressing / to search) only shows the last searched entry, despite repeated presses of the UP arrow.

On windows it also sometimes crashes while pressing UP in search (exits to the shell with code 116). On linux I didn't notice a crash after few attempts.

If not using --incsearch, then all prior search history entries can be accessed with the UP arrow while in search mode.

This happens on both linux and windows.

As far as I can tell, on both linux and windows it's a regression of commit b469710 (towards v647) which is unfortunately quite big...

While bisecting, I think on windows I once noticed a different broken behavior, where pressing UP arrow in search prints HHHH..., and doesn't restore even the last history entry, but I suspect it's a transient failure which got fixed later.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions