Expand 1-month benchmark plot options #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97deee7 to
de2d65e
Compare
de2d65e to
f2bc0b8
Compare
|
@yantosca will test these updates. I was able to successfully generate comparison plots for GCC vs GCC and GCHP vs GCHP. There is an issue with GCC vs GCHP that needs investigation. |
|
Thanks @lizziel. I've rebased this atop of GCPy 1.6.1 since the branch was older than that. Hope to have this sorted out soon. |
Each function does a straight comparison of ref and dev without special handling beyond optionally limiting variable list to variables starting with a specific prefix. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
StateMet is split up into 2D and 3D variable plots. Comparisons include GCC vs GCC, GCHP vs GCC, and GCHP vs GCHP. All new plots are off by default. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
This update is because the 1-month benchmark is run more frequently for debugging and feature validation than the 1-yr benchmark which was previously the default. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
f2bc0b8 to
d1d17c4
Compare
gcpy/benchmark/benchmark_slurm.sh - Set environment variable MPLBACKEND to "agg", which will request a non-interactive matplotlib backend. This is OK since we'll be printing plots directly to PDF files. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
gcpy/benchmark/run_benchmark.py - At the start of each section (GCC vs. GCC, GCHP vs GCC., GCHP vs. GCHP), 2 variables (refmet and devmet) are created to hold the list of met field files to read. We now pass these varaibles to the routines make_benchmark_collection_2d_var_plots and make_benchmark_collection_3d_var_plots for plotting the 2D and 3D StateMet output. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
gcpy/plot_compare_zonal_mean.py - Added code to remove GCHP area variable Met_AREAM2 from the list of variables for which zonal mean comparisons will be made. This variable can show up in when we are creating GCHP vs GCC or GCHP vs GCHP zonal mean plots for the StateMet collection. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
gcpy/util.py
- Implemented the following fixes:
- A variable must have either (lon, lat) or (Xdim, Ydim) are in
both Ref & Dev to be included in the commonvars_data list.
- A variable must not have lev in both Ref & Dev to be included
in the commonvars2D list.
- A variable must have lev in both Ref & Dev to be included
in the commonvars3D list.
gcpy/plot/compare_zonal_mean.py
- Removed the if block that removed Met_AreaM2 from varlist
CHANGELOG.md
- Updated accordingly
Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
|
@msulprizio I am making you a reviewer because @lizziel opened this PR and I pushed the most recent update... so we need 3rd party approval |
|
@lizziel @msulprizio: I fixed a logic error in note, the zonal mean files were too big to attach but the StratZonalMean files are proof that the code works. |
|
Thanks @yantosca for finding and fixing that bug! |
plot/compare_zonal_mean.py - Remove debug print statement - Remove obsolete comments Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
The purpose of this PR is to expand plot capabilities in the 1-month benchmark code to enable easier debugging and validation of GEOS-Chem collections not typically included in the benchmark. It includes the following updates:
make_benchmark_collection_2d_var_plotsandmake_benchmark_collection_3d_var_plotswhich can be used with any GEOS-Chem output collection. Each function does a straight comparison of ref and dev without special handling beyond optionally limiting variable list to variables starting with a specific prefix.Note that the Budget, UVFlux, and StateMet plots all use the new generic collection comparison functions. These may be used as examples to quickly make comparison plots of other collections not configurable in the 1-month benchmark yaml.
Expected changes
This is a no diff update.
Reference(s)
None
Related Github Issue
None