Fix logic for orbit direction time offset #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yantosca
requested changes
May 22, 2025
There was a problem hiding this comment.
Hi @yuanjianz, this looks good to merge but we need a CHANGELOG.md update.
Xarray drop is deprecated and will be replaced by drop_vars
yantosca
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Yuanjian Zhang
Institution: WashU
Describe the update
Fix the logic of ravel_1D program that creates orbit file for 1D GCHP diagnostic
Overpassing time advanced (negative offset) at northern latitudes and delayed (positive offset) at southern latitudes if descending. So time offset needs to be inversed for descending but not ascending.